From: Fam Zheng <famz@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <shajnocz@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use
Date: Fri, 22 Sep 2017 20:59:32 +0800 [thread overview]
Message-ID: <20170922125932.GD32000@lemon> (raw)
In-Reply-To: <20170922101728.GJ12725@redhat.com>
On Fri, 09/22 11:17, Daniel P. Berrange wrote:
> Sorry yes, my bad - its the iothread behind the monitor. I still think that
> is a detail worth keeping private in case we want to refactor how the
> monitor threading works later.
I agree. I convinced Peter to reuse IOThread just because we can, but we don't
need to expose it to user just because we can. Like Daniel, I also see no reason
to do that at this point, and I think we can always do it later when necesssary.
Fam
next prev parent reply other threads:[~2017-09-22 12:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 8:56 [Qemu-devel] [PATCH 0/3] iothread: allow to create internal iothreads Peter Xu
2017-09-22 8:56 ` [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use Peter Xu
2017-09-22 9:04 ` Daniel P. Berrange
2017-09-22 9:14 ` Peter Xu
2017-09-22 9:36 ` Daniel P. Berrange
2017-09-22 9:38 ` Paolo Bonzini
2017-09-22 9:43 ` Daniel P. Berrange
2017-09-22 10:14 ` Paolo Bonzini
2017-09-22 10:17 ` Daniel P. Berrange
2017-09-22 12:59 ` Fam Zheng [this message]
2017-09-22 13:03 ` Paolo Bonzini
2017-09-22 10:54 ` Peter Xu
2017-09-22 10:16 ` Stefan Hajnoczi
2017-09-22 10:18 ` Paolo Bonzini
2017-09-22 10:20 ` Daniel P. Berrange
2017-09-22 10:26 ` Paolo Bonzini
2017-09-22 10:28 ` Daniel P. Berrange
2017-09-22 14:35 ` Stefan Hajnoczi
2017-09-22 14:55 ` Daniel P. Berrange
2017-10-02 17:18 ` Markus Armbruster
2017-10-08 12:46 ` Peter Xu
2017-09-22 8:56 ` [Qemu-devel] [PATCH 2/3] iothread: export iothread_stop() Peter Xu
2017-09-22 13:06 ` Fam Zheng
2017-09-25 3:29 ` Peter Xu
2017-09-22 8:56 ` [Qemu-devel] [PATCH 3/3] iothread: delay the context release to finalize Peter Xu
2017-09-22 13:09 ` Fam Zheng
2017-09-25 5:23 ` Peter Xu
2017-09-25 5:30 ` Fam Zheng
2017-09-25 5:50 ` Peter Xu
2017-09-25 5:58 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922125932.GD32000@lemon \
--to=famz@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shajnocz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).