From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: qemu-devel@nongnu.org
Cc: rth@twiddle.net, laurent@vivier.eu, riku.voipio@iki.fi
Subject: [Qemu-devel] [RFC 0/6] linux-user: refactor socket.h into architecture specific sockbits
Date: Fri, 22 Sep 2017 07:02:31 -0700 [thread overview]
Message-ID: <20170922140237.10869-1-carenas@gmail.com> (raw)
the definitions in socket.h are meant to reflect the ones in linux for each
respective target, but are sometimes difficult to maintain.
hppa (AKA parisc) was initially merged with an independent file that mirrors
more closely the corresponding one in linux but hasn't been updated since.
while testing what should had been a simple change (adding to setsockopt
support for another SO flag) it became obvious that doing this refactor
would help making the code easier to understand and avoid hard to see bugs
(like definitions set to the wrong target as shown for sparc at least)
the changes are somehow mechanical, and I had made an effort to try to identify
what has changed (and hopefully fix a bug), but there is a high probability
something as silly as a typo might have introduced a bug, therefore, testing
for each target is encouraged but not something I could do on my own (being
new to qemu-user and not having access to the corresponding sysroots)
the fact that it is most likely that most socket functions where not working
for sparc, sparc64, mips64 and ppc64 is most likely an indication that more
testing (and regressions) is likely needed around this, so suggestions and
help on that is also needed.
next reply other threads:[~2017-09-22 14:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 14:02 Carlo Marcelo Arenas Belón [this message]
2017-09-22 14:02 ` [Qemu-devel] [RFC 1/6] linux-user: update hppa sockbits Carlo Marcelo Arenas Belón
2017-09-22 16:13 ` Laurent Vivier
2017-09-25 12:40 ` Carlo Arenas
2017-09-22 14:02 ` [Qemu-devel] [RFC 2/6] linux-user: refactor socket.h for alpha Carlo Marcelo Arenas Belón
2017-09-22 16:30 ` Laurent Vivier
2017-09-22 14:02 ` [Qemu-devel] [RFC 3/6] linux-user: refactor socket.h for mips Carlo Marcelo Arenas Belón
2017-09-22 16:41 ` Laurent Vivier
2017-09-22 14:02 ` [Qemu-devel] [RFC 4/6] linux-user: refactor socket.h for sparc Carlo Marcelo Arenas Belón
2017-09-22 16:51 ` Laurent Vivier
2017-09-22 14:02 ` [Qemu-devel] [RFC 5/6] linux-user: fix 64bit versions of sparc and mips Carlo Marcelo Arenas Belón
2017-09-22 17:01 ` Laurent Vivier
2017-09-25 11:44 ` Carlo Arenas
2017-09-22 14:02 ` [Qemu-devel] [RFC 6/6] linux-user: update default socket.h Carlo Marcelo Arenas Belón
2017-09-22 17:04 ` Laurent Vivier
2017-09-25 11:55 ` Carlo Arenas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922140237.10869-1-carenas@gmail.com \
--to=carenas@gmail.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).