From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvULx-0007gZ-92 for qemu-devel@nongnu.org; Fri, 22 Sep 2017 16:15:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvULs-00075a-AN for qemu-devel@nongnu.org; Fri, 22 Sep 2017 16:15:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55334) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dvULs-00074p-1O for qemu-devel@nongnu.org; Fri, 22 Sep 2017 16:15:08 -0400 Date: Fri, 22 Sep 2017 21:15:02 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170922201501.GM2620@work-vm> References: <1504081950-2528-1-git-send-email-peterx@redhat.com> <1504081950-2528-30-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504081950-2528-30-git-send-email-peterx@redhat.com> Subject: Re: [Qemu-devel] [RFC v2 29/33] migration: return incoming task tag for exec List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Laurent Vivier , "Daniel P . Berrange" , Alexey Perevalov , Juan Quintela , Andrea Arcangeli * Peter Xu (peterx@redhat.com) wrote: > Return the async task tag for exec typed incoming migration in > exec_start_incoming_migration(). > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > migration/exec.c | 18 +++++++++++------- > migration/exec.h | 2 +- > 2 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/migration/exec.c b/migration/exec.c > index 08b599e..ef1fb4c 100644 > --- a/migration/exec.c > +++ b/migration/exec.c > @@ -52,7 +52,11 @@ static gboolean exec_accept_incoming_migration(QIOChannel *ioc, > return FALSE; /* unregister */ > } > > -void exec_start_incoming_migration(const char *command, Error **errp) > +/* > + * Returns the tag ID of the watch that is attached to global main > + * loop (>0), or zero if failure detected. > + */ > +guint exec_start_incoming_migration(const char *command, Error **errp) > { > QIOChannel *ioc; > const char *argv[] = { "/bin/sh", "-c", command, NULL }; > @@ -62,13 +66,13 @@ void exec_start_incoming_migration(const char *command, Error **errp) > O_RDWR, > errp)); > if (!ioc) { > - return; > + return 0; > } > > qio_channel_set_name(ioc, "migration-exec-incoming"); > - qio_channel_add_watch(ioc, > - G_IO_IN, > - exec_accept_incoming_migration, > - NULL, > - NULL); > + return qio_channel_add_watch(ioc, > + G_IO_IN, > + exec_accept_incoming_migration, > + NULL, > + NULL); > } > diff --git a/migration/exec.h b/migration/exec.h > index b210ffd..0a7aada 100644 > --- a/migration/exec.h > +++ b/migration/exec.h > @@ -19,7 +19,7 @@ > > #ifndef QEMU_MIGRATION_EXEC_H > #define QEMU_MIGRATION_EXEC_H > -void exec_start_incoming_migration(const char *host_port, Error **errp); > +guint exec_start_incoming_migration(const char *host_port, Error **errp); > > void exec_start_outgoing_migration(MigrationState *s, const char *host_port, > Error **errp); > -- > 2.7.4 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK