From: David Gibson <david@gibson.dropbear.id.au>
To: Thomas Huth <thuth@redhat.com>
Cc: John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, imammedo@redhat.com, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 1/2] ppc: remove unused CPU definitions
Date: Sat, 23 Sep 2017 15:23:36 +1000 [thread overview]
Message-ID: <20170923052336.GF4998@umbus.fritz.box> (raw)
In-Reply-To: <68ca6f8d-5673-4177-fadf-ca512258257b@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3400 bytes --]
On Wed, Sep 20, 2017 at 08:47:43PM +0200, Thomas Huth wrote:
> On 19.09.2017 23:36, John Snow wrote:
> > Following commit aef77960, remove now-unused definitions from
> > cpu-models.h.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> > target/ppc/cpu-models.h | 32 --------------------------------
> > 1 file changed, 32 deletions(-)
> >
> > diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h
> > index df31d7f..b34b512 100644
> > --- a/target/ppc/cpu-models.h
> > +++ b/target/ppc/cpu-models.h
> > @@ -291,34 +291,6 @@ enum {
> > #endif
> > CPU_POWERPC_e200z5 = 0x81000000,
> > CPU_POWERPC_e200z6 = 0x81120000,
> > - /* MPC55xx microcontrollers */
> > -#define CPU_POWERPC_MPC55xx CPU_POWERPC_MPC5567
> > -#if 0
> > -#define CPU_POWERPC_MPC5514E CPU_POWERPC_MPC5514E_v1
> > -#define CPU_POWERPC_MPC5514E_v0 CPU_POWERPC_e200z0
> > -#define CPU_POWERPC_MPC5514E_v1 CPU_POWERPC_e200z1
> > -#define CPU_POWERPC_MPC5514G CPU_POWERPC_MPC5514G_v1
> > -#define CPU_POWERPC_MPC5514G_v0 CPU_POWERPC_e200z0
> > -#define CPU_POWERPC_MPC5514G_v1 CPU_POWERPC_e200z1
> > -#define CPU_POWERPC_MPC5515S CPU_POWERPC_e200z1
> > -#define CPU_POWERPC_MPC5516E CPU_POWERPC_MPC5516E_v1
> > -#define CPU_POWERPC_MPC5516E_v0 CPU_POWERPC_e200z0
> > -#define CPU_POWERPC_MPC5516E_v1 CPU_POWERPC_e200z1
> > -#define CPU_POWERPC_MPC5516G CPU_POWERPC_MPC5516G_v1
> > -#define CPU_POWERPC_MPC5516G_v0 CPU_POWERPC_e200z0
> > -#define CPU_POWERPC_MPC5516G_v1 CPU_POWERPC_e200z1
> > -#define CPU_POWERPC_MPC5516S CPU_POWERPC_e200z1
> > -#endif
> > -#if 0
> > -#define CPU_POWERPC_MPC5533 CPU_POWERPC_e200z3
> > -#define CPU_POWERPC_MPC5534 CPU_POWERPC_e200z3
> > -#endif
> > -#define CPU_POWERPC_MPC5553 CPU_POWERPC_e200z6
> > -#define CPU_POWERPC_MPC5554 CPU_POWERPC_e200z6
> > -#define CPU_POWERPC_MPC5561 CPU_POWERPC_e200z6
> > -#define CPU_POWERPC_MPC5565 CPU_POWERPC_e200z6
> > -#define CPU_POWERPC_MPC5566 CPU_POWERPC_e200z6
> > -#define CPU_POWERPC_MPC5567 CPU_POWERPC_e200z6
> > /* e300 family */
> > /* e300 cores */
> > CPU_POWERPC_e300c1 = 0x00830010,
> > @@ -326,11 +298,7 @@ enum {
> > CPU_POWERPC_e300c3 = 0x00850010,
> > CPU_POWERPC_e300c4 = 0x00860010,
> > /* MPC83xx microcontrollers */
>
> I think you should also remove the above comment now?
>
> > -#define CPU_POWERPC_MPC831x CPU_POWERPC_e300c3
> > -#define CPU_POWERPC_MPC832x CPU_POWERPC_e300c2
> > #define CPU_POWERPC_MPC834x CPU_POWERPC_e300c1
> > -#define CPU_POWERPC_MPC835x CPU_POWERPC_e300c1
> > -#define CPU_POWERPC_MPC836x CPU_POWERPC_e300c1
> > #define CPU_POWERPC_MPC837x CPU_POWERPC_e300c4
> > /* e500 family */
> > /* e500 cores */
>
> With the above comment removed:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
No, there's still one entry left in that subsection, so the comment
should stay. Applied.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-09-23 5:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 21:36 [Qemu-devel] [PATCH 0/2] ppc: remove dead definitions John Snow
2017-09-19 21:36 ` [Qemu-devel] [PATCH 1/2] ppc: remove unused CPU definitions John Snow
2017-09-20 18:47 ` Thomas Huth
2017-09-23 5:23 ` David Gibson [this message]
2017-09-19 21:36 ` [Qemu-devel] [PATCH 2/2] ppc: remove all " John Snow
2017-09-20 18:52 ` Thomas Huth
2017-09-23 5:28 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170923052336.GF4998@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).