* [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"
@ 2017-09-21 17:02 Eduardo Habkost
2017-09-22 2:21 ` Fam Zheng
2017-09-22 3:14 ` Thomas Huth
0 siblings, 2 replies; 6+ messages in thread
From: Eduardo Habkost @ 2017-09-21 17:02 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Fam Zheng, Philippe Mathieu-Daudé
The subsystem name for the "Build test automation" section is
"-------------------------", because an actual subsystem name
line is missing:
$ ./scripts/get_maintainer.pl -f tests/docker/docker.py
"Alex Bennée" <alex.bennee@linaro.org> (maintainer:-----------------...)
Fam Zheng <famz@redhat.com> (maintainer:-----------------...)
"Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:-----------------...)
qemu-devel@nongnu.org (open list:-----------------...)
Fix the issue by inserting a subsystem name line where
get_maintainer.pl expects it.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e511ba780f..13c1ac65b7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
Build and test automation
-------------------------
+Build and test automation
M: Alex Bennée <alex.bennee@linaro.org>
M: Fam Zheng <famz@redhat.com>
R: Philippe Mathieu-Daudé <f4bug@amsat.org>
--
2.13.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"
2017-09-21 17:02 [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation" Eduardo Habkost
@ 2017-09-22 2:21 ` Fam Zheng
2017-09-22 3:14 ` Thomas Huth
1 sibling, 0 replies; 6+ messages in thread
From: Fam Zheng @ 2017-09-22 2:21 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé
On Thu, 09/21 14:02, Eduardo Habkost wrote:
> The subsystem name for the "Build test automation" section is
> "-------------------------", because an actual subsystem name
> line is missing:
>
> $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
> "Alex Bennée" <alex.bennee@linaro.org> (maintainer:-----------------...)
> Fam Zheng <famz@redhat.com> (maintainer:-----------------...)
> "Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:-----------------...)
> qemu-devel@nongnu.org (open list:-----------------...)
>
> Fix the issue by inserting a subsystem name line where
> get_maintainer.pl expects it.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e511ba780f..13c1ac65b7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
>
> Build and test automation
> -------------------------
> +Build and test automation
> M: Alex Bennée <alex.bennee@linaro.org>
> M: Fam Zheng <famz@redhat.com>
> R: Philippe Mathieu-Daudé <f4bug@amsat.org>
> --
> 2.13.5
>
Queued, thanks.
Fam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"
2017-09-21 17:02 [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation" Eduardo Habkost
2017-09-22 2:21 ` Fam Zheng
@ 2017-09-22 3:14 ` Thomas Huth
2017-09-22 3:30 ` Fam Zheng
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2017-09-22 3:14 UTC (permalink / raw)
To: Eduardo Habkost, qemu-devel
Cc: Fam Zheng, Alex Bennée, Philippe Mathieu-Daudé
On 21.09.2017 19:02, Eduardo Habkost wrote:
> The subsystem name for the "Build test automation" section is
> "-------------------------", because an actual subsystem name
> line is missing:
>
> $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
> "Alex Bennée" <alex.bennee@linaro.org> (maintainer:-----------------...)
> Fam Zheng <famz@redhat.com> (maintainer:-----------------...)
> "Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:-----------------...)
> qemu-devel@nongnu.org (open list:-----------------...)
>
> Fix the issue by inserting a subsystem name line where
> get_maintainer.pl expects it.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e511ba780f..13c1ac65b7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
>
> Build and test automation
> -------------------------
> +Build and test automation
Would it make sense to use something more specific here? Like "Travis
and Docker" or so? ... in case we add other subsections in the future?
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"
2017-09-22 3:14 ` Thomas Huth
@ 2017-09-22 3:30 ` Fam Zheng
2017-09-22 21:02 ` Eric Blake
0 siblings, 1 reply; 6+ messages in thread
From: Fam Zheng @ 2017-09-22 3:30 UTC (permalink / raw)
To: Thomas Huth
Cc: Eduardo Habkost, qemu-devel, Alex Bennée,
Philippe Mathieu-Daudé
On Fri, 09/22 05:14, Thomas Huth wrote:
> On 21.09.2017 19:02, Eduardo Habkost wrote:
> > The subsystem name for the "Build test automation" section is
> > "-------------------------", because an actual subsystem name
> > line is missing:
> >
> > $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
> > "Alex Bennée" <alex.bennee@linaro.org> (maintainer:-----------------...)
> > Fam Zheng <famz@redhat.com> (maintainer:-----------------...)
> > "Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:-----------------...)
> > qemu-devel@nongnu.org (open list:-----------------...)
> >
> > Fix the issue by inserting a subsystem name line where
> > get_maintainer.pl expects it.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index e511ba780f..13c1ac65b7 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
> >
> > Build and test automation
> > -------------------------
> > +Build and test automation
>
> Would it make sense to use something more specific here? Like "Travis
> and Docker" or so? ... in case we add other subsections in the future?
Unless we are to split off (i.e. more people volunteering maintaining a certain
subset), the list will just go on and on in this line. For not it's already
going to be "Travis, Shippable, Docker and VM test".. so I think a generic
description here is okay, though the duplication is a bit odd (but I don't have
a better idea).
Fam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"
2017-09-22 3:30 ` Fam Zheng
@ 2017-09-22 21:02 ` Eric Blake
2017-09-25 2:37 ` Fam Zheng
0 siblings, 1 reply; 6+ messages in thread
From: Eric Blake @ 2017-09-22 21:02 UTC (permalink / raw)
To: Fam Zheng, Thomas Huth
Cc: Philippe Mathieu-Daudé, Alex Bennée, Eduardo Habkost,
qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]
On 09/21/2017 10:30 PM, Fam Zheng wrote:
>>> Build and test automation
>>> -------------------------
>>> +Build and test automation
>>
>> Would it make sense to use something more specific here? Like "Travis
>> and Docker" or so? ... in case we add other subsections in the future?
>
> Unless we are to split off (i.e. more people volunteering maintaining a certain
> subset), the list will just go on and on in this line. For not it's already
> going to be "Travis, Shippable, Docker and VM test".. so I think a generic
> description here is okay, though the duplication is a bit odd (but I don't have
> a better idea).
Or we could make a generic section of "Build, Tests, and Documentation",
and merge in the "Build system architecture" of the
immediately-subsequent "Documentation" section, as well as possibly any
future sections for someone to maintain top-level build-related files
(including MAINTAINERS itself...), so that we have just one larger
section with multiple sub-sections, instead of two sections each with
one sub-section.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"
2017-09-22 21:02 ` Eric Blake
@ 2017-09-25 2:37 ` Fam Zheng
0 siblings, 0 replies; 6+ messages in thread
From: Fam Zheng @ 2017-09-25 2:37 UTC (permalink / raw)
To: Eric Blake
Cc: Thomas Huth, Philippe Mathieu-Daudé, Alex Bennée,
Eduardo Habkost, qemu-devel
On Fri, 09/22 16:02, Eric Blake wrote:
> On 09/21/2017 10:30 PM, Fam Zheng wrote:
>
> >>> Build and test automation
> >>> -------------------------
> >>> +Build and test automation
> >>
> >> Would it make sense to use something more specific here? Like "Travis
> >> and Docker" or so? ... in case we add other subsections in the future?
> >
> > Unless we are to split off (i.e. more people volunteering maintaining a certain
> > subset), the list will just go on and on in this line. For not it's already
> > going to be "Travis, Shippable, Docker and VM test".. so I think a generic
> > description here is okay, though the duplication is a bit odd (but I don't have
> > a better idea).
>
> Or we could make a generic section of "Build, Tests, and Documentation",
> and merge in the "Build system architecture" of the
> immediately-subsequent "Documentation" section, as well as possibly any
> future sections for someone to maintain top-level build-related files
> (including MAINTAINERS itself...), so that we have just one larger
> section with multiple sub-sections, instead of two sections each with
> one sub-section.
That sounds okay, but actually most of the files under docs/ don't have a
maintainer, so in the hope that one day they will, the "Documentation" section
may be a good place to host more entries.
Fam
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-09-25 2:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-21 17:02 [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation" Eduardo Habkost
2017-09-22 2:21 ` Fam Zheng
2017-09-22 3:14 ` Thomas Huth
2017-09-22 3:30 ` Fam Zheng
2017-09-22 21:02 ` Eric Blake
2017-09-25 2:37 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).