From: Fam Zheng <famz@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <shajnocz@redhat.com>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] iothread: delay the context release to finalize
Date: Mon, 25 Sep 2017 13:30:02 +0800 [thread overview]
Message-ID: <20170925053002.GA398@lemon.lan> (raw)
In-Reply-To: <20170925052330.GC19505@pxdev.xzpeter.org>
On Mon, 09/25 13:23, Peter Xu wrote:
> On Fri, Sep 22, 2017 at 09:09:22PM +0800, Fam Zheng wrote:
> > On Fri, 09/22 16:56, Peter Xu wrote:
> > > When gcontext is used with iothread, the context will be destroyed
> > > during iothread_stop(). That's not good since sometimes we would like
> > > to keep the resources until iothread is destroyed, but we may want to
> > > stop the thread before that point.
> >
> > Would be nice if you can also mention the glib bug that "required" this in the
> > commit message.
>
> I can add it, but I am not sure it's very closely related (and I'm
> afraid that may confuse more people). Say, even without that bug, I
> would still think it not a good idea to free the context in the loop,
> especially considering that we have the finalize function there. Thanks,
It's interesting to know if or not your future change will break without this
patch, this is especially useful for backport.
Fam
next prev parent reply other threads:[~2017-09-25 5:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 8:56 [Qemu-devel] [PATCH 0/3] iothread: allow to create internal iothreads Peter Xu
2017-09-22 8:56 ` [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use Peter Xu
2017-09-22 9:04 ` Daniel P. Berrange
2017-09-22 9:14 ` Peter Xu
2017-09-22 9:36 ` Daniel P. Berrange
2017-09-22 9:38 ` Paolo Bonzini
2017-09-22 9:43 ` Daniel P. Berrange
2017-09-22 10:14 ` Paolo Bonzini
2017-09-22 10:17 ` Daniel P. Berrange
2017-09-22 12:59 ` Fam Zheng
2017-09-22 13:03 ` Paolo Bonzini
2017-09-22 10:54 ` Peter Xu
2017-09-22 10:16 ` Stefan Hajnoczi
2017-09-22 10:18 ` Paolo Bonzini
2017-09-22 10:20 ` Daniel P. Berrange
2017-09-22 10:26 ` Paolo Bonzini
2017-09-22 10:28 ` Daniel P. Berrange
2017-09-22 14:35 ` Stefan Hajnoczi
2017-09-22 14:55 ` Daniel P. Berrange
2017-10-02 17:18 ` Markus Armbruster
2017-10-08 12:46 ` Peter Xu
2017-09-22 8:56 ` [Qemu-devel] [PATCH 2/3] iothread: export iothread_stop() Peter Xu
2017-09-22 13:06 ` Fam Zheng
2017-09-25 3:29 ` Peter Xu
2017-09-22 8:56 ` [Qemu-devel] [PATCH 3/3] iothread: delay the context release to finalize Peter Xu
2017-09-22 13:09 ` Fam Zheng
2017-09-25 5:23 ` Peter Xu
2017-09-25 5:30 ` Fam Zheng [this message]
2017-09-25 5:50 ` Peter Xu
2017-09-25 5:58 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925053002.GA398@lemon.lan \
--to=famz@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shajnocz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).