From: Eduardo Otubo <otubo@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, ehabkost@redhat.com,
qemu-trivial@nongnu.org, Alexander Graf <agraf@suse.de>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [[PATCH] dma/i82374: avoid double creation of i82374 device
Date: Mon, 25 Sep 2017 11:26:41 +0200 [thread overview]
Message-ID: <20170925092641.GD12137@vader> (raw)
In-Reply-To: <0e84971b-592e-22f7-8815-2b3e193f6c1d@redhat.com>
On Mon, Sep 25, 2017 at 11:11:37AM +0200, Paolo Bonzini wrote:
> On 24/09/2017 23:02, Michael Tokarev wrote:
> > 15.09.2017 12:06, Eduardo Otubo wrote:
> >> QEMU fails when used with the following command line:
> >>
> >> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
> >> qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion `!bus->dma[0] && !bus->dma[1]' failed.
> >> Aborted (core dumped)
> >>
> >> The 40p machine type already creates the device i82374. If specified in the
> >> command line, it will try to create it again, hence generating the error. The
> >> function isa_bus_dma() isn't supposed to be called twice for the same bus. One
> >> way to avoid this problem is to set user_creatable=false.
> >
> > Applied to -trivial, thanks!
>
> Eduardo, weren't you going to send a version that propagates Error*
> correctly instead?
Yes, that's correct. I can revert this patch with the error
propagation patch as well, if you guys don't mind.
next prev parent reply other threads:[~2017-09-25 9:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 9:06 [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device Eduardo Otubo
2017-09-15 9:26 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
2017-09-15 10:18 ` [Qemu-devel] " Paolo Bonzini
2017-09-15 11:53 ` Eduardo Otubo
2017-09-15 22:21 ` Eduardo Habkost
2017-09-16 8:09 ` Paolo Bonzini
2017-09-24 21:02 ` [Qemu-devel] [[PATCH] " Michael Tokarev
2017-09-25 9:11 ` Paolo Bonzini
2017-09-25 9:26 ` Eduardo Otubo [this message]
2017-09-25 9:36 ` Paolo Bonzini
2017-09-25 10:54 ` [Qemu-devel] [PATCH] " Michael Tokarev
2017-09-25 11:25 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2018-03-26 11:18 Eduardo Otubo
2018-03-26 12:14 ` Thomas Huth
2018-03-26 12:16 ` Paolo Bonzini
2018-03-26 15:20 ` Philippe Mathieu-Daudé
2017-09-01 11:03 Eduardo Otubo
2017-09-01 14:30 ` Eduardo Habkost
2017-09-01 15:34 ` Markus Armbruster
2017-09-01 15:44 ` Eduardo Habkost
2017-09-02 9:15 ` Aurelien Jarno
2017-09-07 16:05 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925092641.GD12137@vader \
--to=otubo@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).