From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Fam Zheng <famz@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <shajnocz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/4] iothread: export iothread_stop()
Date: Mon, 25 Sep 2017 10:56:51 +0100 [thread overview]
Message-ID: <20170925095651.GG14140@stefanha-x1.localdomain> (raw)
In-Reply-To: <1506321449-24013-4-git-send-email-peterx@redhat.com>
On Mon, Sep 25, 2017 at 02:37:28PM +0800, Peter Xu wrote:
> So that internal iothread users can explicitly stop one iothread without
> destroying it.
>
> Since at it, fix iothread_stop() to allow it to be called multiple
> times. Before this patch we may call iothread_stop() more than once on
> single iothread, while that may not be correct since qemu_thread_join()
> is not allowed to run twice. From manual of pthread_join():
>
> Joining with a thread that has previously been joined results in
> undefined behavior.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> include/sysemu/iothread.h | 1 +
> iothread.c | 24 ++++++++++++++++--------
> 2 files changed, 17 insertions(+), 8 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2017-09-25 9:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 6:37 [Qemu-devel] [PATCH v2 0/4] iothread: allow to create internal iothreads Peter Xu
2017-09-25 6:37 ` [Qemu-devel] [PATCH v2 1/4] qom: provide root container for internal objs Peter Xu
2017-09-25 7:14 ` Andreas Färber
2017-09-25 8:14 ` Peter Xu
2017-09-25 8:34 ` Manos Pitsidianakis
2017-09-25 9:55 ` Stefan Hajnoczi
2017-09-25 9:00 ` Andreas Färber
2017-09-26 3:18 ` Peter Xu
2017-09-25 9:01 ` Daniel P. Berrange
2017-09-25 6:37 ` [Qemu-devel] [PATCH v2 2/4] iothread: provide helpers for internal use Peter Xu
2017-09-25 6:37 ` [Qemu-devel] [PATCH v2 3/4] iothread: export iothread_stop() Peter Xu
2017-09-25 7:30 ` Fam Zheng
2017-09-25 9:56 ` Stefan Hajnoczi [this message]
2017-09-25 6:37 ` [Qemu-devel] [PATCH v2 4/4] iothread: delay the context release to finalize Peter Xu
2017-09-25 10:00 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925095651.GG14140@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shajnocz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).