qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	peter.maydell@linaro.org, famz@redhat.com, stefanha@redhat.com,
	qemu-block@nongnu.org, qemu-devel@nongnu.org, armbru@redhat.com,
	lirans@il.ibm.com, pbonzini@redhat.com, den@openvz.org,
	mreitz@redhat.com, John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] ping Re: [PATCH v7 03/16] migration: split common postcopy out of ram postcopy
Date: Mon, 25 Sep 2017 15:23:12 +0200	[thread overview]
Message-ID: <20170925132312.GA7999@localhost.localdomain> (raw)
In-Reply-To: <87bmm5k2zs.fsf@secure.laptop>

Am 20.09.2017 um 13:45 hat Juan Quintela geschrieben:
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> > * Vladimir Sementsov-Ogievskiy (vsementsov@virtuozzo.com) wrote:
> >> ping for 1-3
> >> Can we merge them?
> >
> > I see all of them have R-b's; so lets try and put them in the next
> > migration merge.
> >
> > Quintela: Sound good?
> 
> Yeap.

This patch broke qemu-iotests 181 ('Test postcopy live migration with
shared storage'):

--- /home/kwolf/source/qemu/tests/qemu-iotests/181.out  2017-06-16 19:19:53.000000000 +0200
+++ 181.out.bad 2017-09-25 15:20:40.787582000 +0200
@@ -21,18 +21,16 @@
 === Do some I/O on the destination ===
 
 QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) qemu-io disk "read -P 0x55 0 64k"
+(qemu) QEMU_PROG: Expected vmdescription section, but got 0
+QEMU_PROG: Failed to get "write" lock
+Is another process using the image?
+qemu-io disk "read -P 0x55 0 64k"
 read 65536/65536 bytes at offset 0
 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 (qemu) 
 (qemu) qemu-io disk "write -P 0x66 1M 64k"
-wrote 65536/65536 bytes at offset 1048576
-64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-
-=== Shut down and check image ===
-
-(qemu) quit
-(qemu) 
-(qemu) quit
-No errors were found on the image.
-*** done
+QEMU_PROG: block/io.c:1359: bdrv_aligned_pwritev: Assertion `child->perm & BLK_PERM_WRITE' failed.
+./common.config: Aborted                 (core dumped) ( if [ -n "${QEMU_NEED_PID}" ]; then
+echo $BASHPID > "${QEMU_TEST_DIR}/qemu-${_QEMU_HANDLE}.pid";
+fi; exec "$QEMU_PROG" $QEMU_OPTIONS "$@" )
+Timeout waiting for ops/sec on handle 1

  reply	other threads:[~2017-09-25 13:23 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10 16:30 [Qemu-devel] [PATCH v7 00/16] Dirty bitmaps postcopy migration Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 01/16] migration: add has_postcopy savevm handler Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 02/16] migration: fix ram_save_pending Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 03/16] migration: split common postcopy out of ram postcopy Vladimir Sementsov-Ogievskiy
2017-07-11 13:06   ` Dr. David Alan Gilbert
2017-07-11 13:38     ` Vladimir Sementsov-Ogievskiy
2017-08-21 23:34       ` John Snow
2017-09-18 14:07         ` [Qemu-devel] ping " Vladimir Sementsov-Ogievskiy
2017-09-19 19:06           ` Dr. David Alan Gilbert
2017-09-20 11:45             ` Juan Quintela
2017-09-25 13:23               ` Kevin Wolf [this message]
2017-09-25 14:31                 ` Vladimir Sementsov-Ogievskiy
2017-09-25 14:58                   ` Kevin Wolf
2017-09-25 15:07                     ` Vladimir Sementsov-Ogievskiy
2017-09-25 15:27                       ` Dr. David Alan Gilbert
2017-09-26 10:12                         ` Kevin Wolf
2017-09-26 10:21                           ` Dr. David Alan Gilbert
2017-09-26 12:32                             ` Kevin Wolf
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 04/16] migration: introduce postcopy-only pending Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 05/16] block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor() Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 06/16] qapi: add dirty-bitmaps migration capability Vladimir Sementsov-Ogievskiy
2017-07-10 21:03   ` Eric Blake
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 07/16] block/dirty-bitmap: add bdrv_dirty_bitmap_release_successor Vladimir Sementsov-Ogievskiy
2017-08-14  9:37   ` Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 08/16] migration: include migrate_dirty_bitmaps in migrate_postcopy Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 09/16] migration/qemu-file: add qemu_put_counted_string() Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 10/16] migration: add is_active_iterate handler Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 11/16] block/dirty-bitmap: add bdrv_dirty_bitmap_set_frozen Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 12/16] migration: add postcopy migration of dirty bitmaps Vladimir Sementsov-Ogievskiy
2017-09-18 14:07   ` Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 13/16] iotests: add add_incoming_migration to VM class Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 14/16] iotests: add default node-name Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 15/16] iotests: add dirty bitmap migration test Vladimir Sementsov-Ogievskiy
2017-07-10 16:30 ` [Qemu-devel] [PATCH v7 16/16] iotests: add dirty bitmap postcopy test Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170925132312.GA7999@localhost.localdomain \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=dgilbert@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=lirans@il.ibm.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).