From: Peter Xu <peterx@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com, famz@redhat.com,
peter.maydell@linaro.org, cohuck@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int
Date: Tue, 26 Sep 2017 10:31:15 +0800 [thread overview]
Message-ID: <20170926023115.GF19505@pxdev.xzpeter.org> (raw)
In-Reply-To: <20170925112917.21340-2-dgilbert@redhat.com>
On Mon, Sep 25, 2017 at 12:29:12PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Modify the pre_save method on VMStateDescription to return an int
> rather than void so that it potentially can fail.
>
> Changed zillions of devices to make them return 0; the only
> case I've made it return non-0 is hw/intc/s390_flic_kvm.c that already
> had an error_report/return case.
>
> Note: If you add an error exit in your pre_save you must emit
> an error_report to say why.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2017-09-26 2:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 11:29 [Qemu-devel] [PATCH v2 0/6] migration: let pre_save fail Dr. David Alan Gilbert (git)
2017-09-25 11:29 ` [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int Dr. David Alan Gilbert (git)
2017-09-25 13:19 ` Richard Henderson
2017-09-25 13:25 ` Dr. David Alan Gilbert
2017-09-25 13:29 ` Richard Henderson
2017-09-26 2:31 ` Peter Xu [this message]
2017-09-26 13:27 ` Cornelia Huck
2017-09-27 8:57 ` Juan Quintela
2017-09-25 11:29 ` [Qemu-devel] [PATCH v2 2/6] migration: check pre_save return in vmstate_save_state Dr. David Alan Gilbert (git)
2017-09-26 2:36 ` Peter Xu
2017-09-26 13:29 ` Cornelia Huck
2017-09-27 8:58 ` Juan Quintela
2017-09-25 11:29 ` [Qemu-devel] [PATCH v2 3/6] migration: Check field save returns Dr. David Alan Gilbert (git)
2017-09-26 2:42 ` Peter Xu
2017-09-26 13:32 ` Cornelia Huck
2017-09-27 8:59 ` Juan Quintela
2017-09-25 11:29 ` [Qemu-devel] [PATCH v2 4/6] migration: wire vmstate_save_state errors up to vmstate_subsection_save Dr. David Alan Gilbert (git)
2017-09-26 2:45 ` Peter Xu
2017-09-26 9:55 ` Dr. David Alan Gilbert
2017-09-26 13:35 ` Cornelia Huck
2017-09-27 9:00 ` Juan Quintela
2017-09-25 11:29 ` [Qemu-devel] [PATCH v2 5/6] migration: Route errors up through vmstate_save Dr. David Alan Gilbert (git)
2017-09-26 2:56 ` Peter Xu
2017-09-26 13:36 ` Cornelia Huck
2017-09-27 9:00 ` Juan Quintela
2017-09-25 11:29 ` [Qemu-devel] [PATCH v2 6/6] migration: Route more error paths Dr. David Alan Gilbert (git)
2017-09-26 3:06 ` Peter Xu
2017-09-26 10:03 ` Dr. David Alan Gilbert
2017-09-26 13:39 ` Cornelia Huck
2017-09-27 9:07 ` Juan Quintela
2017-09-27 10:51 ` [Qemu-devel] [PATCH v2 0/6] migration: let pre_save fail Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926023115.GF19505@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).