From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwfsl-00023v-Hi for qemu-devel@nongnu.org; Mon, 25 Sep 2017 22:46:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwfsh-0002PG-Ms for qemu-devel@nongnu.org; Mon, 25 Sep 2017 22:45:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34620) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dwfsh-0002OU-Gi for qemu-devel@nongnu.org; Mon, 25 Sep 2017 22:45:55 -0400 Date: Tue, 26 Sep 2017 10:45:48 +0800 From: Peter Xu Message-ID: <20170926024548.GI19505@pxdev.xzpeter.org> References: <20170925112917.21340-1-dgilbert@redhat.com> <20170925112917.21340-5-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170925112917.21340-5-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 4/6] migration: wire vmstate_save_state errors up to vmstate_subsection_save List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, quintela@redhat.com, famz@redhat.com, peter.maydell@linaro.org, cohuck@redhat.com, rth@twiddle.net On Mon, Sep 25, 2017 at 12:29:15PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Route the errors from vmstate_subsection_save up through > vmstate_subsection_save (and back down, all rather recursive). I guess here one of the "vmstate_subsection_save" should be replaced by "vmstate_save_state"? :-) > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Peter Xu