From: Peter Xu <peterx@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, "Fam Zheng" <famz@redhat.com>,
"Manos Pitsidianakis" <el13635@mail.ntua.gr>,
"Markus Armbruster" <armbru@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Stefan Hajnoczi" <shajnocz@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3 1/4] qom: provide root container for internal objs
Date: Tue, 26 Sep 2017 16:49:28 +0800 [thread overview]
Message-ID: <20170926084928.GB3828@pxdev.xzpeter.org> (raw)
In-Reply-To: <20170926084616.GC16834@stefanha-x1.localdomain>
On Tue, Sep 26, 2017 at 09:46:16AM +0100, Stefan Hajnoczi wrote:
> On Tue, Sep 26, 2017 at 12:52:09PM +0800, Peter Xu wrote:
> > diff --git a/include/qom/object.h b/include/qom/object.h
> > index f3e5cff..f567052 100644
> > --- a/include/qom/object.h
> > +++ b/include/qom/object.h
> > @@ -1214,6 +1214,16 @@ Object *object_get_root(void);
> > Object *object_get_objects_root(void);
> >
> > /**
> > + * object_get_internal_root:
> > + *
> > + * Get the container object that holds internally used object
> > + * instances. This is the object at path "/internal-objects"
>
> When you update the comment, please mention that this root is for
> objects that must not be user-visible. This root is not exposed in the
> qom tree.
>
> I think mentioning this will help others understand the purpose of the
> internal root.
Sure. Will do.
--
Peter Xu
next prev parent reply other threads:[~2017-09-26 8:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 4:52 [Qemu-devel] [PATCH v3 0/4] iothread: allow to create internal iothreads Peter Xu
2017-09-26 4:52 ` [Qemu-devel] [PATCH v3 1/4] qom: provide root container for internal objs Peter Xu
2017-09-26 4:58 ` Fam Zheng
2017-09-26 5:12 ` Peter Xu
2017-09-26 8:46 ` Stefan Hajnoczi
2017-09-26 8:49 ` Peter Xu [this message]
2017-09-26 4:52 ` [Qemu-devel] [PATCH v3 2/4] iothread: provide helpers for internal use Peter Xu
2017-09-26 4:59 ` Fam Zheng
2017-09-26 8:46 ` Stefan Hajnoczi
2017-09-26 4:52 ` [Qemu-devel] [PATCH v3 3/4] iothread: export iothread_stop() Peter Xu
2017-09-26 4:52 ` [Qemu-devel] [PATCH v3 4/4] iothread: delay the context release to finalize Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926084928.GB3828@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=el13635@mail.ntua.gr \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shajnocz@redhat.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).