From: Cornelia Huck <cohuck@redhat.com>
To: Pierre Morel <pmorel@linux.vnet.ibm.com>
Cc: Halil Pasic <pasic@linux.vnet.ibm.com>,
Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 3/5] virtio-ccw: use ccw data stream
Date: Tue, 26 Sep 2017 12:10:27 +0200 [thread overview]
Message-ID: <20170926121027.735e5126.cohuck@redhat.com> (raw)
In-Reply-To: <7e694ed6-7b40-c895-9542-e445489cda18@linux.vnet.ibm.com>
On Fri, 22 Sep 2017 17:39:35 +0200
Pierre Morel <pmorel@linux.vnet.ibm.com> wrote:
> On 21/09/2017 20:08, Halil Pasic wrote:
> > Replace direct access which implicitly assumes no IDA
> > or MIDA with the new ccw data stream interface which should
> > cope with these transparently in the future.
> >
> > Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> > Reviewed-by: Pierre Morel<pmorel@linux.vnet.ibm.com>
> > Reviewed-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
> > ---
> > hw/s390x/virtio-ccw.c | 155 +++++++++++++++-----------------------------------
> > 1 file changed, 46 insertions(+), 109 deletions(-)
> LGTM.
> Not testing the return value for ccw_dstream_read/write_buf() bother me
> but I can understand that you will modify this later.
> May be a comment?
> Not a strong opinion.
I can add "Note that checking the return code for ccw_dstream_* will be
done in a follow-on patch."
>
> Reviewed-by: Pierre Morel<pmorel@linux.vnet.ibm.com>
>
>
next prev parent reply other threads:[~2017-09-26 10:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 18:08 [Qemu-devel] [PATCH v4 0/5] add CCW indirect data access support Halil Pasic
2017-09-21 18:08 ` [Qemu-devel] [PATCH v4 1/5] s390x/css: introduce css data stream Halil Pasic
2017-09-21 18:08 ` [Qemu-devel] [PATCH v4 2/5] s390x/css: use ccw " Halil Pasic
2017-09-21 18:08 ` [Qemu-devel] [PATCH v4 3/5] virtio-ccw: " Halil Pasic
2017-09-22 15:39 ` Pierre Morel
2017-09-26 10:10 ` Cornelia Huck [this message]
2017-09-26 10:14 ` Halil Pasic
2017-09-21 18:08 ` [Qemu-devel] [PATCH v4 4/5] 390x/css: introduce maximum data address checking Halil Pasic
2017-09-22 12:35 ` Pierre Morel
2017-09-25 3:05 ` Dong Jia Shi
2017-09-21 18:08 ` [Qemu-devel] [PATCH v4 5/5] s390x/css: support ccw IDA Halil Pasic
2017-09-25 3:14 ` Dong Jia Shi
2017-09-26 10:18 ` [Qemu-devel] [PATCH v4 0/5] add CCW indirect data access support Cornelia Huck
2017-09-26 10:45 ` Halil Pasic
2017-09-26 11:19 ` Cornelia Huck
2017-09-26 12:59 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926121027.735e5126.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).