From: Cornelia Huck <cohuck@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com, peterx@redhat.com,
famz@redhat.com, peter.maydell@linaro.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int
Date: Tue, 26 Sep 2017 15:27:46 +0200 [thread overview]
Message-ID: <20170926152746.1bd31900.cohuck@redhat.com> (raw)
In-Reply-To: <20170925112917.21340-2-dgilbert@redhat.com>
On Mon, 25 Sep 2017 12:29:12 +0100
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Modify the pre_save method on VMStateDescription to return an int
> rather than void so that it potentially can fail.
>
> Changed zillions of devices to make them return 0; the only
> case I've made it return non-0 is hw/intc/s390_flic_kvm.c that already
> had an error_report/return case.
>
> Note: If you add an error exit in your pre_save you must emit
> an error_report to say why.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> docs/devel/migration.txt | 2 +-
> hw/arm/pxa2xx.c | 4 +++-
> hw/arm/strongarm.c | 4 +++-
> hw/audio/wm8750.c | 4 +++-
> hw/block/fdc.c | 4 +++-
> hw/block/m25p80.c | 4 +++-
> hw/block/nand.c | 4 +++-
> hw/block/onenand.c | 4 +++-
> hw/char/serial.c | 4 +++-
> hw/display/qxl.c | 4 +++-
> hw/i2c/core.c | 4 +++-
> hw/i386/kvm/clock.c | 4 +++-
> hw/ide/core.c | 4 +++-
> hw/ide/pci.c | 4 +++-
> hw/input/ps2.c | 8 ++++++--
> hw/input/tsc210x.c | 4 +++-
> hw/intc/apic_common.c | 4 +++-
> hw/intc/arm_gic_common.c | 4 +++-
> hw/intc/arm_gicv3_common.c | 4 +++-
> hw/intc/arm_gicv3_its_common.c | 4 +++-
> hw/intc/i8259_common.c | 4 +++-
> hw/intc/ioapic_common.c | 4 +++-
> hw/intc/s390_flic_kvm.c | 6 ++++--
> hw/intc/xics.c | 8 ++++++--
> hw/net/e1000.c | 4 +++-
> hw/net/e1000e.c | 4 +++-
> hw/net/rtl8139.c | 4 +++-
> hw/net/virtio-net.c | 16 ++++++++++++----
> hw/net/vmxnet3.c | 4 +++-
> hw/pci-host/piix.c | 4 +++-
> hw/ppc/ppc.c | 4 +++-
> hw/ppc/spapr_iommu.c | 4 +++-
> hw/ppc/spapr_pci.c | 6 ++++--
> hw/s390x/css.c | 10 +++++++---
> hw/s390x/virtio-ccw.c | 4 +++-
> hw/scsi/lsi53c895a.c | 4 +++-
> hw/scsi/vmw_pvscsi.c | 4 +++-
> hw/timer/cadence_ttc.c | 4 +++-
> hw/timer/hpet.c | 4 +++-
> hw/timer/i8254_common.c | 4 +++-
> hw/timer/mc146818rtc.c | 4 +++-
> hw/timer/pl031.c | 4 +++-
> hw/timer/twl92230.c | 4 +++-
> hw/usb/dev-smartcard-reader.c | 4 +++-
> hw/usb/hcd-ehci.c | 4 +++-
> hw/usb/redirect.c | 4 +++-
> hw/virtio/vhost-vsock.c | 4 +++-
> include/migration/vmstate.h | 2 +-
> migration/colo-comm.c | 4 +++-
> migration/global_state.c | 4 +++-
> migration/savevm.c | 4 +++-
> replay/replay-snapshot.c | 4 +++-
> slirp/slirp.c | 8 ++++++--
> target/arm/machine.c | 4 +++-
> target/i386/machine.c | 7 +++++--
> target/ppc/machine.c | 4 +++-
> target/s390x/machine.c | 4 +++-
> target/sparc/machine.c | 4 +++-
> tests/test-vmstate.c | 4 +++-
> 59 files changed, 199 insertions(+), 70 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2017-09-26 13:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 11:29 [Qemu-devel] [PATCH v2 0/6] migration: let pre_save fail Dr. David Alan Gilbert (git)
2017-09-25 11:29 ` [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int Dr. David Alan Gilbert (git)
2017-09-25 13:19 ` Richard Henderson
2017-09-25 13:25 ` Dr. David Alan Gilbert
2017-09-25 13:29 ` Richard Henderson
2017-09-26 2:31 ` Peter Xu
2017-09-26 13:27 ` Cornelia Huck [this message]
2017-09-27 8:57 ` Juan Quintela
2017-09-25 11:29 ` [Qemu-devel] [PATCH v2 2/6] migration: check pre_save return in vmstate_save_state Dr. David Alan Gilbert (git)
2017-09-26 2:36 ` Peter Xu
2017-09-26 13:29 ` Cornelia Huck
2017-09-27 8:58 ` Juan Quintela
2017-09-25 11:29 ` [Qemu-devel] [PATCH v2 3/6] migration: Check field save returns Dr. David Alan Gilbert (git)
2017-09-26 2:42 ` Peter Xu
2017-09-26 13:32 ` Cornelia Huck
2017-09-27 8:59 ` Juan Quintela
2017-09-25 11:29 ` [Qemu-devel] [PATCH v2 4/6] migration: wire vmstate_save_state errors up to vmstate_subsection_save Dr. David Alan Gilbert (git)
2017-09-26 2:45 ` Peter Xu
2017-09-26 9:55 ` Dr. David Alan Gilbert
2017-09-26 13:35 ` Cornelia Huck
2017-09-27 9:00 ` Juan Quintela
2017-09-25 11:29 ` [Qemu-devel] [PATCH v2 5/6] migration: Route errors up through vmstate_save Dr. David Alan Gilbert (git)
2017-09-26 2:56 ` Peter Xu
2017-09-26 13:36 ` Cornelia Huck
2017-09-27 9:00 ` Juan Quintela
2017-09-25 11:29 ` [Qemu-devel] [PATCH v2 6/6] migration: Route more error paths Dr. David Alan Gilbert (git)
2017-09-26 3:06 ` Peter Xu
2017-09-26 10:03 ` Dr. David Alan Gilbert
2017-09-26 13:39 ` Cornelia Huck
2017-09-27 9:07 ` Juan Quintela
2017-09-27 10:51 ` [Qemu-devel] [PATCH v2 0/6] migration: let pre_save fail Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926152746.1bd31900.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).