From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwpu3-0001GR-N3 for qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:28:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwptz-0001Te-NN for qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:27:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41502) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dwptz-0001SF-EZ for qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:27:55 -0400 Date: Tue, 26 Sep 2017 15:27:46 +0200 From: Cornelia Huck Message-ID: <20170926152746.1bd31900.cohuck@redhat.com> In-Reply-To: <20170925112917.21340-2-dgilbert@redhat.com> References: <20170925112917.21340-1-dgilbert@redhat.com> <20170925112917.21340-2-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, quintela@redhat.com, peterx@redhat.com, famz@redhat.com, peter.maydell@linaro.org, rth@twiddle.net On Mon, 25 Sep 2017 12:29:12 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Modify the pre_save method on VMStateDescription to return an int > rather than void so that it potentially can fail. > > Changed zillions of devices to make them return 0; the only > case I've made it return non-0 is hw/intc/s390_flic_kvm.c that already > had an error_report/return case. > > Note: If you add an error exit in your pre_save you must emit > an error_report to say why. > > Signed-off-by: Dr. David Alan Gilbert > --- > docs/devel/migration.txt | 2 +- > hw/arm/pxa2xx.c | 4 +++- > hw/arm/strongarm.c | 4 +++- > hw/audio/wm8750.c | 4 +++- > hw/block/fdc.c | 4 +++- > hw/block/m25p80.c | 4 +++- > hw/block/nand.c | 4 +++- > hw/block/onenand.c | 4 +++- > hw/char/serial.c | 4 +++- > hw/display/qxl.c | 4 +++- > hw/i2c/core.c | 4 +++- > hw/i386/kvm/clock.c | 4 +++- > hw/ide/core.c | 4 +++- > hw/ide/pci.c | 4 +++- > hw/input/ps2.c | 8 ++++++-- > hw/input/tsc210x.c | 4 +++- > hw/intc/apic_common.c | 4 +++- > hw/intc/arm_gic_common.c | 4 +++- > hw/intc/arm_gicv3_common.c | 4 +++- > hw/intc/arm_gicv3_its_common.c | 4 +++- > hw/intc/i8259_common.c | 4 +++- > hw/intc/ioapic_common.c | 4 +++- > hw/intc/s390_flic_kvm.c | 6 ++++-- > hw/intc/xics.c | 8 ++++++-- > hw/net/e1000.c | 4 +++- > hw/net/e1000e.c | 4 +++- > hw/net/rtl8139.c | 4 +++- > hw/net/virtio-net.c | 16 ++++++++++++---- > hw/net/vmxnet3.c | 4 +++- > hw/pci-host/piix.c | 4 +++- > hw/ppc/ppc.c | 4 +++- > hw/ppc/spapr_iommu.c | 4 +++- > hw/ppc/spapr_pci.c | 6 ++++-- > hw/s390x/css.c | 10 +++++++--- > hw/s390x/virtio-ccw.c | 4 +++- > hw/scsi/lsi53c895a.c | 4 +++- > hw/scsi/vmw_pvscsi.c | 4 +++- > hw/timer/cadence_ttc.c | 4 +++- > hw/timer/hpet.c | 4 +++- > hw/timer/i8254_common.c | 4 +++- > hw/timer/mc146818rtc.c | 4 +++- > hw/timer/pl031.c | 4 +++- > hw/timer/twl92230.c | 4 +++- > hw/usb/dev-smartcard-reader.c | 4 +++- > hw/usb/hcd-ehci.c | 4 +++- > hw/usb/redirect.c | 4 +++- > hw/virtio/vhost-vsock.c | 4 +++- > include/migration/vmstate.h | 2 +- > migration/colo-comm.c | 4 +++- > migration/global_state.c | 4 +++- > migration/savevm.c | 4 +++- > replay/replay-snapshot.c | 4 +++- > slirp/slirp.c | 8 ++++++-- > target/arm/machine.c | 4 +++- > target/i386/machine.c | 7 +++++-- > target/ppc/machine.c | 4 +++- > target/s390x/machine.c | 4 +++- > target/sparc/machine.c | 4 +++- > tests/test-vmstate.c | 4 +++- > 59 files changed, 199 insertions(+), 70 deletions(-) Reviewed-by: Cornelia Huck