* [Qemu-devel] [RFC PATCH] tests/docker/run: don't source /etc/profile
@ 2017-09-26 13:36 Alex Bennée
2017-09-26 16:17 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Alex Bennée @ 2017-09-26 13:36 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Philippe Mathieu-Daudé, Fam Zheng
The usual behaviour of /etc/profile is to set the default PATH for
users. This runs into problems when we have updated PATH in our
dockerfile e.g. to access a cross-compiler in a non-standard
location. It shouldn't be needed anyway as we inherit the env from the
image when it was setup.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
CC: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
tests/docker/run | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/docker/run b/tests/docker/run
index c8f940de15..b87f8ef03c 100755
--- a/tests/docker/run
+++ b/tests/docker/run
@@ -18,7 +18,6 @@ fi
BASE="$(dirname $(readlink -e $0))"
# Prepare the environment
-. /etc/profile
export PATH=/usr/lib/ccache:$PATH
if test -n "$J"; then
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [RFC PATCH] tests/docker/run: don't source /etc/profile
2017-09-26 13:36 [Qemu-devel] [RFC PATCH] tests/docker/run: don't source /etc/profile Alex Bennée
@ 2017-09-26 16:17 ` Philippe Mathieu-Daudé
2017-09-27 5:46 ` Fam Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-09-26 16:17 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Fam Zheng
On 09/26/2017 10:36 AM, Alex Bennée wrote:
> The usual behaviour of /etc/profile is to set the default PATH for
> users. This runs into problems when we have updated PATH in our
> dockerfile e.g. to access a cross-compiler in a non-standard
> location. It shouldn't be needed anyway as we inherit the env from the
> image when it was setup.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/docker/run | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/docker/run b/tests/docker/run
> index c8f940de15..b87f8ef03c 100755
> --- a/tests/docker/run
> +++ b/tests/docker/run
> @@ -18,7 +18,6 @@ fi
> BASE="$(dirname $(readlink -e $0))"
>
> # Prepare the environment
> -. /etc/profile
> export PATH=/usr/lib/ccache:$PATH
>
> if test -n "$J"; then
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [RFC PATCH] tests/docker/run: don't source /etc/profile
2017-09-26 16:17 ` Philippe Mathieu-Daudé
@ 2017-09-27 5:46 ` Fam Zheng
0 siblings, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2017-09-27 5:46 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: Alex Bennée, qemu-devel
On Tue, 09/26 13:17, Philippe Mathieu-Daudé wrote:
> On 09/26/2017 10:36 AM, Alex Bennée wrote:
> > The usual behaviour of /etc/profile is to set the default PATH for
> > users. This runs into problems when we have updated PATH in our
> > dockerfile e.g. to access a cross-compiler in a non-standard
> > location. It shouldn't be needed anyway as we inherit the env from the
> > image when it was setup.
> >
> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Queued, thanks.
Fam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-27 5:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-26 13:36 [Qemu-devel] [RFC PATCH] tests/docker/run: don't source /etc/profile Alex Bennée
2017-09-26 16:17 ` Philippe Mathieu-Daudé
2017-09-27 5:46 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).