* [Qemu-devel] [PATCH] s390x/cpumodel: remove ais from z14 default model-> also for 2.10.1
@ 2017-09-26 18:05 Christian Borntraeger
2017-09-26 18:26 ` David Hildenbrand
0 siblings, 1 reply; 7+ messages in thread
From: Christian Borntraeger @ 2017-09-26 18:05 UTC (permalink / raw)
To: Cornelia Huck
Cc: qemu-devel, Alexander Graf, Thomas Huth, David Hildenbrand,
Richard Henderson, Michael Roth, Christian Borntraeger
We disabled ais for 2.10 lets also remove it from the z14 default model.
Fixes: 3f2d07b3b01e s390x/ais: for 2.10 stable: disable ais facility
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
target/s390x/gen-features.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
index c8dc104..68e6c31 100644
--- a/target/s390x/gen-features.c
+++ b/target/s390x/gen-features.c
@@ -527,7 +527,6 @@ static uint16_t default_GEN13_GA1[] = {
#define default_GEN13_GA2 EmptyFeat
static uint16_t default_GEN14_GA1[] = {
- S390_FEAT_ADAPTER_INT_SUPPRESSION,
S390_FEAT_INSTRUCTION_EXEC_PROT,
S390_FEAT_GUARDED_STORAGE,
S390_FEAT_VECTOR_PACKED_DECIMAL,
--
2.9.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] s390x/cpumodel: remove ais from z14 default model-> also for 2.10.1
2017-09-26 18:05 [Qemu-devel] [PATCH] s390x/cpumodel: remove ais from z14 default model-> also for 2.10.1 Christian Borntraeger
@ 2017-09-26 18:26 ` David Hildenbrand
2017-09-27 7:39 ` Cornelia Huck
0 siblings, 1 reply; 7+ messages in thread
From: David Hildenbrand @ 2017-09-26 18:26 UTC (permalink / raw)
To: Christian Borntraeger, Cornelia Huck
Cc: qemu-devel, Alexander Graf, Thomas Huth, Richard Henderson,
Michael Roth
On 26.09.2017 20:05, Christian Borntraeger wrote:
> We disabled ais for 2.10 lets also remove it from the z14 default model.
>
> Fixes: 3f2d07b3b01e s390x/ais: for 2.10 stable: disable ais facility
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> target/s390x/gen-features.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> index c8dc104..68e6c31 100644
> --- a/target/s390x/gen-features.c
> +++ b/target/s390x/gen-features.c
> @@ -527,7 +527,6 @@ static uint16_t default_GEN13_GA1[] = {
> #define default_GEN13_GA2 EmptyFeat
>
> static uint16_t default_GEN14_GA1[] = {
> - S390_FEAT_ADAPTER_INT_SUPPRESSION,
> S390_FEAT_INSTRUCTION_EXEC_PROT,
> S390_FEAT_GUARDED_STORAGE,
> S390_FEAT_VECTOR_PACKED_DECIMAL,
>
Yes, this has to go into stable, otherwise the migration safe stable
model would be changed.
Apart from that, this looks just fine.
--
Thanks,
David
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] s390x/cpumodel: remove ais from z14 default model-> also for 2.10.1
2017-09-26 18:26 ` David Hildenbrand
@ 2017-09-27 7:39 ` Cornelia Huck
2017-09-27 7:41 ` Christian Borntraeger
0 siblings, 1 reply; 7+ messages in thread
From: Cornelia Huck @ 2017-09-27 7:39 UTC (permalink / raw)
To: David Hildenbrand
Cc: Christian Borntraeger, qemu-devel, Alexander Graf, Thomas Huth,
Richard Henderson, Michael Roth
On Tue, 26 Sep 2017 20:26:31 +0200
David Hildenbrand <david@redhat.com> wrote:
> On 26.09.2017 20:05, Christian Borntraeger wrote:
> > We disabled ais for 2.10 lets also remove it from the z14 default model.
> >
> > Fixes: 3f2d07b3b01e s390x/ais: for 2.10 stable: disable ais facility
> > Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> > ---
> > target/s390x/gen-features.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> > index c8dc104..68e6c31 100644
> > --- a/target/s390x/gen-features.c
> > +++ b/target/s390x/gen-features.c
> > @@ -527,7 +527,6 @@ static uint16_t default_GEN13_GA1[] = {
> > #define default_GEN13_GA2 EmptyFeat
> >
> > static uint16_t default_GEN14_GA1[] = {
> > - S390_FEAT_ADAPTER_INT_SUPPRESSION,
> > S390_FEAT_INSTRUCTION_EXEC_PROT,
> > S390_FEAT_GUARDED_STORAGE,
> > S390_FEAT_VECTOR_PACKED_DECIMAL,
> >
>
> Yes, this has to go into stable, otherwise the migration safe stable
> model would be changed.
>
> Apart from that, this looks just fine.
So, this should go into stable only, as the patches currently on the
list will fix this properly for 2.11, right?
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] s390x/cpumodel: remove ais from z14 default model-> also for 2.10.1
2017-09-27 7:39 ` Cornelia Huck
@ 2017-09-27 7:41 ` Christian Borntraeger
2017-09-27 8:57 ` Cornelia Huck
0 siblings, 1 reply; 7+ messages in thread
From: Christian Borntraeger @ 2017-09-27 7:41 UTC (permalink / raw)
To: Cornelia Huck, David Hildenbrand
Cc: qemu-devel, Alexander Graf, Thomas Huth, Richard Henderson,
Michael Roth
On 09/27/2017 09:39 AM, Cornelia Huck wrote:
> On Tue, 26 Sep 2017 20:26:31 +0200
> David Hildenbrand <david@redhat.com> wrote:
>
>> On 26.09.2017 20:05, Christian Borntraeger wrote:
>>> We disabled ais for 2.10 lets also remove it from the z14 default model.
>>>
>>> Fixes: 3f2d07b3b01e s390x/ais: for 2.10 stable: disable ais facility
>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> ---
>>> target/s390x/gen-features.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
>>> index c8dc104..68e6c31 100644
>>> --- a/target/s390x/gen-features.c
>>> +++ b/target/s390x/gen-features.c
>>> @@ -527,7 +527,6 @@ static uint16_t default_GEN13_GA1[] = {
>>> #define default_GEN13_GA2 EmptyFeat
>>>
>>> static uint16_t default_GEN14_GA1[] = {
>>> - S390_FEAT_ADAPTER_INT_SUPPRESSION,
>>> S390_FEAT_INSTRUCTION_EXEC_PROT,
>>> S390_FEAT_GUARDED_STORAGE,
>>> S390_FEAT_VECTOR_PACKED_DECIMAL,
>>>
>>
>> Yes, this has to go into stable, otherwise the migration safe stable
>> model would be changed.
>>
>> Apart from that, this looks just fine.
>
> So, this should go into stable only, as the patches currently on the
> list will fix this properly for 2.11, right?
No this also has to go into 2.11 (otherwise the default model for z14 would differ)
so maybe change the subject when applying.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] s390x/cpumodel: remove ais from z14 default model-> also for 2.10.1
2017-09-27 7:41 ` Christian Borntraeger
@ 2017-09-27 8:57 ` Cornelia Huck
2017-09-27 9:09 ` Christian Borntraeger
0 siblings, 1 reply; 7+ messages in thread
From: Cornelia Huck @ 2017-09-27 8:57 UTC (permalink / raw)
To: Christian Borntraeger
Cc: David Hildenbrand, qemu-devel, Alexander Graf, Thomas Huth,
Richard Henderson, Michael Roth
On Wed, 27 Sep 2017 09:41:21 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> On 09/27/2017 09:39 AM, Cornelia Huck wrote:
> > On Tue, 26 Sep 2017 20:26:31 +0200
> > David Hildenbrand <david@redhat.com> wrote:
> >
> >> On 26.09.2017 20:05, Christian Borntraeger wrote:
> >>> We disabled ais for 2.10 lets also remove it from the z14 default model.
> >>>
> >>> Fixes: 3f2d07b3b01e s390x/ais: for 2.10 stable: disable ais facility
> >>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> >>> ---
> >>> target/s390x/gen-features.c | 1 -
> >>> 1 file changed, 1 deletion(-)
> >>>
> >>> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> >>> index c8dc104..68e6c31 100644
> >>> --- a/target/s390x/gen-features.c
> >>> +++ b/target/s390x/gen-features.c
> >>> @@ -527,7 +527,6 @@ static uint16_t default_GEN13_GA1[] = {
> >>> #define default_GEN13_GA2 EmptyFeat
> >>>
> >>> static uint16_t default_GEN14_GA1[] = {
> >>> - S390_FEAT_ADAPTER_INT_SUPPRESSION,
> >>> S390_FEAT_INSTRUCTION_EXEC_PROT,
> >>> S390_FEAT_GUARDED_STORAGE,
> >>> S390_FEAT_VECTOR_PACKED_DECIMAL,
> >>>
> >>
> >> Yes, this has to go into stable, otherwise the migration safe stable
> >> model would be changed.
> >>
> >> Apart from that, this looks just fine.
> >
> > So, this should go into stable only, as the patches currently on the
> > list will fix this properly for 2.11, right?
>
> No this also has to go into 2.11 (otherwise the default model for z14 would differ)
> so maybe change the subject when applying.
>
OK, so it looks like I should do the following:
- Get this upstream as a single patch so that it does not miss the
2.10.1 train.
- Send another pull with the ais(yours)/phb(mine)/whatever(I hope
that's it...) fixups once we're confident about those.
Agreed?
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] s390x/cpumodel: remove ais from z14 default model-> also for 2.10.1
2017-09-27 8:57 ` Cornelia Huck
@ 2017-09-27 9:09 ` Christian Borntraeger
2017-09-27 9:13 ` Cornelia Huck
0 siblings, 1 reply; 7+ messages in thread
From: Christian Borntraeger @ 2017-09-27 9:09 UTC (permalink / raw)
To: Cornelia Huck
Cc: David Hildenbrand, qemu-devel, Alexander Graf, Thomas Huth,
Richard Henderson, Michael Roth
On 09/27/2017 10:57 AM, Cornelia Huck wrote:
> On Wed, 27 Sep 2017 09:41:21 +0200
> Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>
>> On 09/27/2017 09:39 AM, Cornelia Huck wrote:
>>> On Tue, 26 Sep 2017 20:26:31 +0200
>>> David Hildenbrand <david@redhat.com> wrote:
>>>
>>>> On 26.09.2017 20:05, Christian Borntraeger wrote:
>>>>> We disabled ais for 2.10 lets also remove it from the z14 default model.
>>>>>
>>>>> Fixes: 3f2d07b3b01e s390x/ais: for 2.10 stable: disable ais facility
>>>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>>>> ---
>>>>> target/s390x/gen-features.c | 1 -
>>>>> 1 file changed, 1 deletion(-)
>>>>>
>>>>> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
>>>>> index c8dc104..68e6c31 100644
>>>>> --- a/target/s390x/gen-features.c
>>>>> +++ b/target/s390x/gen-features.c
>>>>> @@ -527,7 +527,6 @@ static uint16_t default_GEN13_GA1[] = {
>>>>> #define default_GEN13_GA2 EmptyFeat
>>>>>
>>>>> static uint16_t default_GEN14_GA1[] = {
>>>>> - S390_FEAT_ADAPTER_INT_SUPPRESSION,
>>>>> S390_FEAT_INSTRUCTION_EXEC_PROT,
>>>>> S390_FEAT_GUARDED_STORAGE,
>>>>> S390_FEAT_VECTOR_PACKED_DECIMAL,
>>>>>
>>>>
>>>> Yes, this has to go into stable, otherwise the migration safe stable
>>>> model would be changed.
>>>>
>>>> Apart from that, this looks just fine.
>>>
>>> So, this should go into stable only, as the patches currently on the
>>> list will fix this properly for 2.11, right?
>>
>> No this also has to go into 2.11 (otherwise the default model for z14 would differ)
>> so maybe change the subject when applying.
>>
>
> OK, so it looks like I should do the following:
> - Get this upstream as a single patch so that it does not miss the
> 2.10.1 train.
Can you add the Cc stable? I forgot that.
> - Send another pull with the ais(yours)/phb(mine)/whatever(I hope
> that's it...) fixups once we're confident about those.
yes.
>
> Agreed?
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] s390x/cpumodel: remove ais from z14 default model-> also for 2.10.1
2017-09-27 9:09 ` Christian Borntraeger
@ 2017-09-27 9:13 ` Cornelia Huck
0 siblings, 0 replies; 7+ messages in thread
From: Cornelia Huck @ 2017-09-27 9:13 UTC (permalink / raw)
To: Christian Borntraeger
Cc: David Hildenbrand, qemu-devel, Alexander Graf, Thomas Huth,
Richard Henderson, Michael Roth
On Wed, 27 Sep 2017 11:09:28 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> On 09/27/2017 10:57 AM, Cornelia Huck wrote:
> > On Wed, 27 Sep 2017 09:41:21 +0200
> > Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> >
> >> On 09/27/2017 09:39 AM, Cornelia Huck wrote:
> >>> On Tue, 26 Sep 2017 20:26:31 +0200
> >>> David Hildenbrand <david@redhat.com> wrote:
> >>>
> >>>> On 26.09.2017 20:05, Christian Borntraeger wrote:
> >>>>> We disabled ais for 2.10 lets also remove it from the z14 default model.
> >>>>>
> >>>>> Fixes: 3f2d07b3b01e s390x/ais: for 2.10 stable: disable ais facility
> >>>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> >>>>> ---
> >>>>> target/s390x/gen-features.c | 1 -
> >>>>> 1 file changed, 1 deletion(-)
> >>>>>
> >>>>> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> >>>>> index c8dc104..68e6c31 100644
> >>>>> --- a/target/s390x/gen-features.c
> >>>>> +++ b/target/s390x/gen-features.c
> >>>>> @@ -527,7 +527,6 @@ static uint16_t default_GEN13_GA1[] = {
> >>>>> #define default_GEN13_GA2 EmptyFeat
> >>>>>
> >>>>> static uint16_t default_GEN14_GA1[] = {
> >>>>> - S390_FEAT_ADAPTER_INT_SUPPRESSION,
> >>>>> S390_FEAT_INSTRUCTION_EXEC_PROT,
> >>>>> S390_FEAT_GUARDED_STORAGE,
> >>>>> S390_FEAT_VECTOR_PACKED_DECIMAL,
> >>>>>
> >>>>
> >>>> Yes, this has to go into stable, otherwise the migration safe stable
> >>>> model would be changed.
> >>>>
> >>>> Apart from that, this looks just fine.
> >>>
> >>> So, this should go into stable only, as the patches currently on the
> >>> list will fix this properly for 2.11, right?
> >>
> >> No this also has to go into 2.11 (otherwise the default model for z14 would differ)
> >> so maybe change the subject when applying.
> >>
> >
> > OK, so it looks like I should do the following:
> > - Get this upstream as a single patch so that it does not miss the
> > 2.10.1 train.
>
> Can you add the Cc stable? I forgot that.
Huh, me too. Fixing up.
>
> > - Send another pull with the ais(yours)/phb(mine)/whatever(I hope
> > that's it...) fixups once we're confident about those.
>
> yes.
> >
> > Agreed?
> >
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-09-27 9:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-26 18:05 [Qemu-devel] [PATCH] s390x/cpumodel: remove ais from z14 default model-> also for 2.10.1 Christian Borntraeger
2017-09-26 18:26 ` David Hildenbrand
2017-09-27 7:39 ` Cornelia Huck
2017-09-27 7:41 ` Christian Borntraeger
2017-09-27 8:57 ` Cornelia Huck
2017-09-27 9:09 ` Christian Borntraeger
2017-09-27 9:13 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).