From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45394)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1dxBaC-0007fM-2h
	for qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:36:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1dxBaB-0001SA-7K
	for qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:36:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42988)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <famz@redhat.com>) id 1dxBaB-0001S1-1H
	for qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:36:55 -0400
Date: Wed, 27 Sep 2017 20:36:46 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20170927123646.GA8521@lemon.lan>
References: <20170926054439.GB25267@pxdev.xzpeter.org>
	<20170926084337.GB16834@stefanha-x1.localdomain>
	<20170926091150.GC3828@pxdev.xzpeter.org>
	<20170926111343.GE31924@lemon.lan>
	<20170927121753.GB14579@stefanha-x1.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170927121753.GB14579@stefanha-x1.localdomain>
Subject: Re: [Qemu-devel] A glib warning encountered with internal iothread
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Peter Xu <peterx@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, QEMU Devel Mailing List <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

On Wed, 09/27 13:17, Stefan Hajnoczi wrote:
> On Tue, Sep 26, 2017 at 07:13:43PM +0800, Fam Zheng wrote:
> > On Tue, 09/26 17:11, Peter Xu wrote:
> >  void aio_context_unref(AioContext *ctx)
> >  {
> > +    assert(ctx->refcnt > 0);
> > +    if (--ctx->refcnt == 0) {
> > +        aio_set_event_notifier(ctx, &ctx->notifier, false, NULL, NULL);
> > +    }
> 
> This isn't a general solution because Linux AIO also has a file
> descriptor that is removed in aio_ctx_finalize().

Right. Another option is to move everything in aio_context_finalize() into the
"if (--ctx->refcnt == 0) { ... }" block, before calling g_source_unref().

Fam