From: "Daniel P. Berrange" <berrange@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, "Lukáš Doktor" <ldoktor@redhat.com>,
"Fam Zheng" <famz@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/5] basevm: Call logging.basicConfig()
Date: Wed, 27 Sep 2017 14:19:57 +0100 [thread overview]
Message-ID: <20170927131957.GI12223@redhat.com> (raw)
In-Reply-To: <20170927130339.21444-4-ehabkost@redhat.com>
On Wed, Sep 27, 2017 at 10:03:37AM -0300, Eduardo Habkost wrote:
> Just setting level=DEBUG when debug is enabled is not enough: we
> need to set up a log handler if we want debug messages generated
> using logging.getLogger(...).debug() to be printed.
>
> This was not a problem before because logging.debug() calls
> logging.basicConfig() implicitly, but it's safer to not rely on
> that.
>
> Cc: "Alex Bennée" <alex.bennee@linaro.org>
> Cc: Fam Zheng <famz@redhat.com>
> Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> tests/vm/basevm.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-09-27 13:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 13:03 [Qemu-devel] [PATCH 0/5] scripts: Remove 'debug' parameter from QEMUMachine & QEMUMonitorProtocol Eduardo Habkost
2017-09-27 13:03 ` [Qemu-devel] [PATCH 1/5] guestperf: Configure logging on all shell frontends Eduardo Habkost
2017-09-27 13:17 ` Daniel P. Berrange
2017-09-28 9:15 ` Lukáš Doktor
2017-09-28 13:19 ` Eduardo Habkost
2017-09-27 13:03 ` [Qemu-devel] [PATCH 2/5] iotests: Set up Python logging Eduardo Habkost
2017-09-27 13:17 ` Daniel P. Berrange
2017-09-28 8:54 ` Lukáš Doktor
2017-09-27 13:03 ` [Qemu-devel] [PATCH 3/5] basevm: Call logging.basicConfig() Eduardo Habkost
2017-09-27 13:19 ` Daniel P. Berrange [this message]
2017-09-27 13:35 ` Fam Zheng
2017-09-27 13:40 ` Eduardo Habkost
2017-09-28 9:24 ` Lukáš Doktor
2017-09-27 13:03 ` [Qemu-devel] [PATCH 4/5] scripts: Remove debug parameter from QEMUMonitorProtocol Eduardo Habkost
2017-09-27 13:20 ` Daniel P. Berrange
2017-09-27 13:33 ` Fam Zheng
2017-09-27 13:41 ` Eduardo Habkost
2017-09-27 13:44 ` [Qemu-devel] [PATCH] fixup! " Eduardo Habkost
2017-09-28 9:33 ` Lukáš Doktor
2017-09-28 14:01 ` Eduardo Habkost
2017-09-27 13:03 ` [Qemu-devel] [PATCH 5/5] scripts: Remove debug parameter from QEMUMachine Eduardo Habkost
2017-09-27 13:22 ` Daniel P. Berrange
2017-09-27 13:38 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927131957.GI12223@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=ldoktor@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).