* [Qemu-devel] [PATCH] xen-hvm: use errno in error message
@ 2017-09-27 16:10 Wei Liu
2017-09-27 16:13 ` Wei Liu
2017-09-27 16:33 ` Anthony PERARD
0 siblings, 2 replies; 3+ messages in thread
From: Wei Liu @ 2017-09-27 16:10 UTC (permalink / raw)
To: qemu-devel; +Cc: Xen-devel, Wei Liu, Stefano Stabellini, Anthony PERARD
The error code is encoding in errno, not rc.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
---
hw/i386/xen/xen-hvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index d9ccd5d0d6..f79816a649 100644
--- a/hw/i386/xen/xen-hvm.c
+++ b/hw/i386/xen/xen-hvm.c
@@ -1446,7 +1446,7 @@ void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length)
if (rc) {
fprintf(stderr,
"%s failed for "RAM_ADDR_FMT" ("RAM_ADDR_FMT"): %i, %s\n",
- __func__, start, nb_pages, rc, strerror(-rc));
+ __func__, start, nb_pages, rc, strerror(errno));
}
}
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] xen-hvm: use errno in error message
2017-09-27 16:10 [Qemu-devel] [PATCH] xen-hvm: use errno in error message Wei Liu
@ 2017-09-27 16:13 ` Wei Liu
2017-09-27 16:33 ` Anthony PERARD
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2017-09-27 16:13 UTC (permalink / raw)
To: qemu-devel; +Cc: Xen-devel, Wei Liu, Stefano Stabellini, Anthony PERARD
On Wed, Sep 27, 2017 at 05:10:09PM +0100, Wei Liu wrote:
> The error code is encoding in errno, not rc.
>
"is encoded", sorry for the typo...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] xen-hvm: use errno in error message
2017-09-27 16:10 [Qemu-devel] [PATCH] xen-hvm: use errno in error message Wei Liu
2017-09-27 16:13 ` Wei Liu
@ 2017-09-27 16:33 ` Anthony PERARD
1 sibling, 0 replies; 3+ messages in thread
From: Anthony PERARD @ 2017-09-27 16:33 UTC (permalink / raw)
To: Wei Liu; +Cc: qemu-devel, Xen-devel, Stefano Stabellini
On Wed, Sep 27, 2017 at 05:10:09PM +0100, Wei Liu wrote:
> The error code is encoding in errno, not rc.
^ encoded
I think.
Otherwise,
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Anthony PERARD <anthony.perard@citrix.com>
> ---
> hw/i386/xen/xen-hvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
> index d9ccd5d0d6..f79816a649 100644
> --- a/hw/i386/xen/xen-hvm.c
> +++ b/hw/i386/xen/xen-hvm.c
> @@ -1446,7 +1446,7 @@ void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length)
> if (rc) {
> fprintf(stderr,
> "%s failed for "RAM_ADDR_FMT" ("RAM_ADDR_FMT"): %i, %s\n",
> - __func__, start, nb_pages, rc, strerror(-rc));
> + __func__, start, nb_pages, rc, strerror(errno));
> }
> }
> }
> --
> 2.11.0
>
--
Anthony PERARD
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-27 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-27 16:10 [Qemu-devel] [PATCH] xen-hvm: use errno in error message Wei Liu
2017-09-27 16:13 ` Wei Liu
2017-09-27 16:33 ` Anthony PERARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).