From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 1/2] vl: Eliminate defconfig variable
Date: Wed, 27 Sep 2017 17:32:24 -0300 [thread overview]
Message-ID: <20170927203225.30896-2-ehabkost@redhat.com> (raw)
In-Reply-To: <20170927203225.30896-1-ehabkost@redhat.com>
Both -nodefconfig and -no-user-config options do the same thing
today, we only need one variable to keep track of them.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
vl.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index 4fd01fda91..b347a97a5b 100644
--- a/vl.c
+++ b/vl.c
@@ -3093,7 +3093,6 @@ int main(int argc, char **argv, char **envp)
const char *qtest_log = NULL;
const char *pid_file = NULL;
const char *incoming = NULL;
- bool defconfig = true;
bool userconfig = true;
bool nographic = false;
DisplayType display_type = DT_DEFAULT;
@@ -3194,8 +3193,6 @@ int main(int argc, char **argv, char **envp)
popt = lookup_opt(argc, argv, &optarg, &optind);
switch (popt->index) {
case QEMU_OPTION_nodefconfig:
- defconfig = false;
- break;
case QEMU_OPTION_nouserconfig:
userconfig = false;
break;
@@ -3203,7 +3200,7 @@ int main(int argc, char **argv, char **envp)
}
}
- if (defconfig && userconfig) {
+ if (userconfig) {
if (qemu_read_default_config_file() < 0) {
exit(1);
}
--
2.13.5
next prev parent reply other threads:[~2017-09-27 20:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 20:32 [Qemu-devel] [PATCH 0/2] Deprecate -nodefconfig Eduardo Habkost
2017-09-27 20:32 ` Eduardo Habkost [this message]
2017-09-27 22:27 ` [Qemu-devel] [PATCH 1/2] vl: Eliminate defconfig variable Alistair Francis
2017-09-28 11:42 ` Daniel P. Berrange
2017-09-28 11:44 ` Daniel P. Berrange
2017-09-28 12:50 ` Eduardo Habkost
2017-10-02 8:48 ` Markus Armbruster
2017-09-27 20:32 ` [Qemu-devel] [PATCH 2/2] qemu-options: Deprecate -nodefconfig Eduardo Habkost
2017-09-27 22:27 ` Alistair Francis
2017-10-02 8:48 ` Markus Armbruster
2017-09-28 11:34 ` [Qemu-devel] [PATCH 0/2] " Paolo Bonzini
2017-09-28 11:40 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927203225.30896-2-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).