From: Kevin Wolf <kwolf@redhat.com>
To: Jan Dakinevich <jan.dakinevich@virtuozzo.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Cornelia Huck <cohuck@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>, Amit Shah <amit@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
"Denis V. Lunev" <den@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command
Date: Thu, 28 Sep 2017 12:02:35 +0200 [thread overview]
Message-ID: <20170928100235.GA5826@localhost.localdomain> (raw)
In-Reply-To: <0aa2a34c-c97e-36ea-8d9d-317483a6944f@virtuozzo.com>
Am 28.09.2017 um 01:05 hat Jan Dakinevich geschrieben:
> > OK but if it's useful as an hmp command, why not as a qmp command?
>
> The command is designed for debugging and produces quite sightly output. For
> respective qmp command most of `info virtio' output would excessive and
> unneccesary.
The general policy is that HMP commands should only call QMP command
implementations internally rather than doing things themselves, to make
sure that a management tool can achieve everything the monitor provides
with QMP and doesn't have to fall back to parsing HMP output.
If we are certain that this feature is useless for automated use and
nobody will ever want to use it in scripts (sounds like a bold claim to
me), maybe an exception can be justified. I think this is up to the
monitor maintainers.
Kevin
next prev parent reply other threads:[~2017-09-28 10:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 15:09 [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command Jan Dakinevich
2017-09-27 15:53 ` Dr. David Alan Gilbert
2017-09-27 17:33 ` Jan Dakinevich
2017-09-27 19:43 ` Michael S. Tsirkin
2017-09-27 23:05 ` Jan Dakinevich
2017-09-28 10:02 ` Kevin Wolf [this message]
2017-09-28 10:12 ` Cornelia Huck
2017-09-28 10:41 ` Dr. David Alan Gilbert
2017-09-28 10:14 ` Daniel P. Berrange
2017-09-28 10:25 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928100235.GA5826@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=amit@kernel.org \
--cc=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=den@virtuozzo.com \
--cc=dgilbert@redhat.com \
--cc=jan.dakinevich@virtuozzo.com \
--cc=jasowang@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).