From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxWG7-0006QK-54 for qemu-devel@nongnu.org; Thu, 28 Sep 2017 06:41:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxWG6-0001Qc-DY for qemu-devel@nongnu.org; Thu, 28 Sep 2017 06:41:35 -0400 Date: Thu, 28 Sep 2017 11:41:15 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170928104115.GC2130@work-vm> References: <1506524982-4053-1-git-send-email-jan.dakinevich@virtuozzo.com> <20170927224308-mutt-send-email-mst@kernel.org> <0aa2a34c-c97e-36ea-8d9d-317483a6944f@virtuozzo.com> <20170928100235.GA5826@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170928100235.GA5826@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Jan Dakinevich , "Michael S. Tsirkin" , qemu-devel@nongnu.org, qemu-block@nongnu.org, Cornelia Huck , Stefan Hajnoczi , Max Reitz , Amit Shah , Paolo Bonzini , Jason Wang , Markus Armbruster , "Denis V. Lunev" * Kevin Wolf (kwolf@redhat.com) wrote: > Am 28.09.2017 um 01:05 hat Jan Dakinevich geschrieben: > > > OK but if it's useful as an hmp command, why not as a qmp command? > > > > The command is designed for debugging and produces quite sightly output. For > > respective qmp command most of `info virtio' output would excessive and > > unneccesary. > > The general policy is that HMP commands should only call QMP command > implementations internally rather than doing things themselves, to make > sure that a management tool can achieve everything the monitor provides > with QMP and doesn't have to fall back to parsing HMP output. > > If we are certain that this feature is useless for automated use and > nobody will ever want to use it in scripts (sounds like a bold claim to > me), maybe an exception can be justified. I think this is up to the > monitor maintainers. I'm happy to add debug-only commands as HMP-only; but if there is a use for the data from QMP then I agree they should be built upon QMP; I'll leave that to virtio people to answer that distinction. Dave > Kevin -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK