From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxXCl-0002yz-2b for qemu-devel@nongnu.org; Thu, 28 Sep 2017 07:42:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxXCh-0005aO-Qx for qemu-devel@nongnu.org; Thu, 28 Sep 2017 07:42:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59739) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dxXCh-0005a8-Kx for qemu-devel@nongnu.org; Thu, 28 Sep 2017 07:42:07 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9693C43854 for ; Thu, 28 Sep 2017 11:42:06 +0000 (UTC) Date: Thu, 28 Sep 2017 12:42:02 +0100 From: "Daniel P. Berrange" Message-ID: <20170928114202.GJ12919@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170927203225.30896-1-ehabkost@redhat.com> <20170927203225.30896-2-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170927203225.30896-2-ehabkost@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] vl: Eliminate defconfig variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Paolo Bonzini , Markus Armbruster On Wed, Sep 27, 2017 at 05:32:24PM -0300, Eduardo Habkost wrote: > Both -nodefconfig and -no-user-config options do the same thing > today, we only need one variable to keep track of them. What reason for picking -nodefconfig instead of -no-user-config to deprecate ? -nodefconfig predates -no-user-config by a few years, and is what libvirt has historically used. So from libvirt POV we'd have a slight preference to deprecate -no-user-config instead and keep -nodefconfig, simply to avoid need to add conditional logic to libvirt to pick which to use. > > Suggested-by: Markus Armbruster > Signed-off-by: Eduardo Habkost > --- > vl.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/vl.c b/vl.c > index 4fd01fda91..b347a97a5b 100644 > --- a/vl.c > +++ b/vl.c > @@ -3093,7 +3093,6 @@ int main(int argc, char **argv, char **envp) > const char *qtest_log = NULL; > const char *pid_file = NULL; > const char *incoming = NULL; > - bool defconfig = true; > bool userconfig = true; > bool nographic = false; > DisplayType display_type = DT_DEFAULT; > @@ -3194,8 +3193,6 @@ int main(int argc, char **argv, char **envp) > popt = lookup_opt(argc, argv, &optarg, &optind); > switch (popt->index) { > case QEMU_OPTION_nodefconfig: > - defconfig = false; > - break; > case QEMU_OPTION_nouserconfig: > userconfig = false; > break; > @@ -3203,7 +3200,7 @@ int main(int argc, char **argv, char **envp) > } > } > > - if (defconfig && userconfig) { > + if (userconfig) { > if (qemu_read_default_config_file() < 0) { > exit(1); > } > -- > 2.13.5 > > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|