qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] vl: Eliminate defconfig variable
Date: Thu, 28 Sep 2017 12:44:01 +0100	[thread overview]
Message-ID: <20170928114401.GK12919@redhat.com> (raw)
In-Reply-To: <20170928114202.GJ12919@redhat.com>

On Thu, Sep 28, 2017 at 12:42:02PM +0100, Daniel P. Berrange wrote:
> On Wed, Sep 27, 2017 at 05:32:24PM -0300, Eduardo Habkost wrote:
> > Both -nodefconfig and -no-user-config options do the same thing
> > today, we only need one variable to keep track of them.
> 
> What reason for picking -nodefconfig instead of -no-user-config to
> deprecate ?  -nodefconfig predates -no-user-config by a few years,
> and is what libvirt has historically used. So from libvirt POV
> we'd have a slight preference to deprecate -no-user-config instead
> and keep -nodefconfig, simply to avoid need to add conditional
> logic to libvirt to pick which to use.

Actually never mind, I just noticed libvirt actually supports
both options and dynamically detects their existance.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  reply	other threads:[~2017-09-28 11:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27 20:32 [Qemu-devel] [PATCH 0/2] Deprecate -nodefconfig Eduardo Habkost
2017-09-27 20:32 ` [Qemu-devel] [PATCH 1/2] vl: Eliminate defconfig variable Eduardo Habkost
2017-09-27 22:27   ` Alistair Francis
2017-09-28 11:42   ` Daniel P. Berrange
2017-09-28 11:44     ` Daniel P. Berrange [this message]
2017-09-28 12:50     ` Eduardo Habkost
2017-10-02  8:48   ` Markus Armbruster
2017-09-27 20:32 ` [Qemu-devel] [PATCH 2/2] qemu-options: Deprecate -nodefconfig Eduardo Habkost
2017-09-27 22:27   ` Alistair Francis
2017-10-02  8:48   ` Markus Armbruster
2017-09-28 11:34 ` [Qemu-devel] [PATCH 0/2] " Paolo Bonzini
2017-09-28 11:40 ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170928114401.GK12919@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).