qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <famz@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Daniel P. Berrange" <berrange@redhat.com>
Subject: [Qemu-devel] [PATCH v8 6/6] ui: don't export qemu_input_event_new_key
Date: Fri, 29 Sep 2017 11:12:01 +0100	[thread overview]
Message-ID: <20170929101201.21039-7-berrange@redhat.com> (raw)
In-Reply-To: <20170929101201.21039-1-berrange@redhat.com>

All public code should use qemu_input_event_send_key* functions
instead of creating an event directly.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 include/ui/input.h | 1 -
 ui/input.c         | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/ui/input.h b/include/ui/input.h
index 479cc46cfc..f8cee43f65 100644
--- a/include/ui/input.h
+++ b/include/ui/input.h
@@ -38,7 +38,6 @@ void qemu_input_event_send_impl(QemuConsole *src, InputEvent *evt);
 void qemu_input_event_sync(void);
 void qemu_input_event_sync_impl(void);
 
-InputEvent *qemu_input_event_new_key(KeyValue *key, bool down);
 void qemu_input_event_send_key(QemuConsole *src, KeyValue *key, bool down);
 void qemu_input_event_send_key_number(QemuConsole *src, int num, bool down);
 void qemu_input_event_send_key_qcode(QemuConsole *src, QKeyCode q, bool down);
diff --git a/ui/input.c b/ui/input.c
index 4b241aa823..290b47354a 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -386,7 +386,7 @@ void qemu_input_event_sync(void)
     replay_input_sync_event();
 }
 
-InputEvent *qemu_input_event_new_key(KeyValue *key, bool down)
+static InputEvent *qemu_input_event_new_key(KeyValue *key, bool down)
 {
     InputEvent *evt = g_new0(InputEvent, 1);
     evt->u.key.data = g_new0(InputKeyEvent, 1);
-- 
2.13.5

  parent reply	other threads:[~2017-09-29 10:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29 10:11 [Qemu-devel] [PATCH v8 0/6] Initial support for keycodemapdb GIT submodule Daniel P. Berrange
2017-09-29 10:11 ` [Qemu-devel] [PATCH v8 1/6] build: automatically handle GIT submodule checkout for dtc Daniel P. Berrange
2017-09-29 10:11 ` [Qemu-devel] [PATCH v8 2/6] docker: don't rely on submodules existing in the main checkout Daniel P. Berrange
2017-10-02 12:52   ` Alex Bennée
2017-10-02 13:01     ` Daniel P. Berrange
2017-09-29 10:11 ` [Qemu-devel] [PATCH v8 3/6] ui: add keycodemapdb repository as a GIT submodule Daniel P. Berrange
2017-09-29 10:11 ` [Qemu-devel] [PATCH v8 4/6] ui: convert common input code to keycodemapdb Daniel P. Berrange
2017-09-29 10:12 ` [Qemu-devel] [PATCH v8 5/6] ui: convert key events to QKeyCodes immediately Daniel P. Berrange
2017-09-29 10:12 ` Daniel P. Berrange [this message]
2017-10-02  9:56 ` [Qemu-devel] [PATCH v8 0/6] Initial support for keycodemapdb GIT submodule Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170929101201.21039-7-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=famz@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).