From: "Daniel P. Berrange" <berrange@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] websock: treat upgrade header in case insensitive way
Date: Fri, 29 Sep 2017 17:19:45 +0100 [thread overview]
Message-ID: <20170929161945.GI11930@redhat.com> (raw)
In-Reply-To: <20170929145629.14766-1-den@openvz.org>
On Fri, Sep 29, 2017 at 05:56:29PM +0300, Denis V. Lunev wrote:
> According to rfc6455 section 4.2.1. Reading the Client's Opening Handshake
> An |Upgrade| header field containing the value "websocket",
> treated as an ASCII case-insensitive value.
>
> Current implementation in QEMU accepts this header in lower-case only,
> which is revealed to have broken some real-life clients. We need to
> convert the value of this header to lower case before comparison.
> Unfortunately we can not do that for all headers. Only this specific one
> should be converted this way.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Daniel P. Berrange <berrange@redhat.com>
FYI, I already have a fix for this problem queued:
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02982.html
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-09-29 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 14:56 [Qemu-devel] [PATCH 1/1] websock: treat upgrade header in case insensitive way Denis V. Lunev
2017-09-29 16:19 ` Daniel P. Berrange [this message]
2017-09-29 17:07 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929161945.GI11930@redhat.com \
--to=berrange@redhat.com \
--cc=den@openvz.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).