From: "Tomáš Golembiovský" <tgolembi@redhat.com>
To: Chen Hanxiao <chen_han_xiao@126.com>
Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qga-win: fall back to hardcoded user and group names if LookupAccountSidW failed
Date: Fri, 29 Sep 2017 23:31:02 +0200 [thread overview]
Message-ID: <20170929233102.4b068e2f@fiorina> (raw)
In-Reply-To: <20170929091122.22726-1-chen_han_xiao@126.com>
On Fri, 29 Sep 2017 17:11:22 +0800
Chen Hanxiao <chen_han_xiao@126.com> wrote:
> From: Chen Hanxiao <chenhanxiao@gmail.com>
>
> On some of windows (win08 sp2),
> it doesn't work by calling LookupAccountSidW with
> well-known SIDs,
> We got an error:
> error 997 overlapped I/O operation is in progress
>
> But hardcoded names work.
>
> This patch introduces a workaroud for this issue:
> if LookupAccountSidW failed, try hardcoded one.
>
> Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
> ---
> qga/vss-win32/install.cpp | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
I wonder if it's caused by qga itself or a race/conflict with some other
app. But still...
Reviewed-by: Tomáš Golembiovský <tgolembi@redhat.com>
--
Tomáš Golembiovský <tgolembi@redhat.com>
next prev parent reply other threads:[~2017-09-29 21:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 9:11 [Qemu-devel] [PATCH] qga-win: fall back to hardcoded user and group names if LookupAccountSidW failed Chen Hanxiao
2017-09-29 21:31 ` Tomáš Golembiovský [this message]
2017-10-25 21:58 ` Michael Roth
2017-10-26 9:27 ` Chen Hanxiao
2017-10-26 9:59 ` Michael Roth
2017-10-26 11:01 ` Chen Hanxiao
2017-10-26 13:54 ` Tomáš Golembiovský
2017-10-27 1:05 ` Michael Roth
2017-11-02 10:58 ` Chen Hanxiao
2017-11-03 11:16 ` Tomáš Golembiovský
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929233102.4b068e2f@fiorina \
--to=tgolembi@redhat.com \
--cc=chen_han_xiao@126.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).