From: <jiang.biao2@zte.com.cn>
To: yongbok.kim@imgtec.com
Cc: f4bug@amsat.org, aurelien@aurel32.net, zhong.weidong@zte.com.cn,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target/mips: remove commented out codes intranslate.c
Date: Sat, 30 Sep 2017 08:38:06 +0800 (CST) [thread overview]
Message-ID: <201709300838065627716@zte.com.cn> (raw)
In-Reply-To: b70bb6ae-9cac-06e6-c65e-1fd11b8308db@imgtec.com
> On 29/09/2017 10:58, Philippe Mathieu-Daudé wrote:
> > Hi Jiang,
> >
> > I'm not sure it is really helpful to remove those comment, they are here as
> > debt to the project, reminding what should be implemented.
> >
> > Are you proposing to accept this instructions will never get implemented?
> >
> > Regards,
> >
> > Phil.
>>
>
> Hi Phil,
>
> The commented codes are all trivial. When the time we implement those
> features it is merely copy & paste from the specification. I don't think
> there is much harm to remove the comments.
> Besides there is TODO file in the same directory but that has not been
> updated for a while, perhaps updating the file is much relevant with this
> patch.
Can't agree more :), it should be better put the reminder in other place
rather in release code.
Regards,
Jiang
reply other threads:[~2017-09-30 0:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201709300838065627716@zte.com.cn \
--to=jiang.biao2@zte.com.cn \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=yongbok.kim@imgtec.com \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).