From: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
Anthoine Bourgeois <anthoine.bourgeois@gmail.com>,
Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
Subject: [Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer
Date: Mon, 2 Oct 2017 10:09:06 +0200 [thread overview]
Message-ID: <20171002080906.4682-1-anthoine.bourgeois@gmail.com> (raw)
From: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
The gd_gl_area_scanout_texture must destroy framebuffer if there is
no texture id instead of no framebuffer id.
The effect was a black screen with "-vga virtio -display gtk,gl=on"
options.
The bug was introduce by a4f113fd "gtk: use framebuffer helper functions."
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
---
ui/gtk-gl-area.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 18b298f..026b7d7 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl,
gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area));
- if (vc->gfx.guest_fb.framebuffer == 0 ||
- vc->gfx.w == 0 || vc->gfx.h == 0) {
+ if (backing_id == 0 || vc->gfx.w == 0 || vc->gfx.h == 0) {
gtk_gl_area_set_scanout_mode(vc, false);
return;
}
--
2.9.3
next reply other threads:[~2017-10-02 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 8:09 Anthoine Bourgeois [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-02 10:07 [Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer Anthoine Bourgeois
2017-10-02 12:40 Anthoine Bourgeois
2017-11-08 12:49 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002080906.4682-1-anthoine.bourgeois@gmail.com \
--to=anthoine.bourgeois@gmail.com \
--cc=anthoine.bourgeois@blade-group.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).