* [Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer
@ 2017-10-02 8:09 Anthoine Bourgeois
0 siblings, 0 replies; 4+ messages in thread
From: Anthoine Bourgeois @ 2017-10-02 8:09 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
Cc: qemu-trivial, Anthoine Bourgeois, Anthoine Bourgeois
From: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
The gd_gl_area_scanout_texture must destroy framebuffer if there is
no texture id instead of no framebuffer id.
The effect was a black screen with "-vga virtio -display gtk,gl=on"
options.
The bug was introduce by a4f113fd "gtk: use framebuffer helper functions."
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
---
ui/gtk-gl-area.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 18b298f..026b7d7 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl,
gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area));
- if (vc->gfx.guest_fb.framebuffer == 0 ||
- vc->gfx.w == 0 || vc->gfx.h == 0) {
+ if (backing_id == 0 || vc->gfx.w == 0 || vc->gfx.h == 0) {
gtk_gl_area_set_scanout_mode(vc, false);
return;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer
@ 2017-10-02 10:07 Anthoine Bourgeois
0 siblings, 0 replies; 4+ messages in thread
From: Anthoine Bourgeois @ 2017-10-02 10:07 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel; +Cc: qemu-trivial, Anthoine Bourgeois
The gd_gl_area_scanout_texture must destroy framebuffer if there is
no texture id instead of no framebuffer id.
The effect was a black screen with "-vga virtio -display gtk,gl=on"
options.
The bug was introduce by a4f113fd "gtk: use framebuffer helper functions."
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
---
ui/gtk-gl-area.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 18b298f..026b7d7 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl,
gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area));
- if (vc->gfx.guest_fb.framebuffer == 0 ||
- vc->gfx.w == 0 || vc->gfx.h == 0) {
+ if (backing_id == 0 || vc->gfx.w == 0 || vc->gfx.h == 0) {
gtk_gl_area_set_scanout_mode(vc, false);
return;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer
@ 2017-10-02 12:40 Anthoine Bourgeois
2017-11-08 12:49 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Anthoine Bourgeois @ 2017-10-02 12:40 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Anthoine Bourgeois
From: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
The gd_gl_area_scanout_texture must destroy framebuffer if there is
no texture id instead of no framebuffer id.
The effect was a black screen with "-vga virtio -display gtk,gl=on"
options.
The bug was introduce by a4f113fd "gtk: use framebuffer helper functions."
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
---
ui/gtk-gl-area.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 18b298f..026b7d7 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl,
gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area));
- if (vc->gfx.guest_fb.framebuffer == 0 ||
- vc->gfx.w == 0 || vc->gfx.h == 0) {
+ if (backing_id == 0 || vc->gfx.w == 0 || vc->gfx.h == 0) {
gtk_gl_area_set_scanout_mode(vc, false);
return;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer
2017-10-02 12:40 Anthoine Bourgeois
@ 2017-11-08 12:49 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-11-08 12:49 UTC (permalink / raw)
To: Anthoine Bourgeois, Gerd Hoffmann
Cc: qemu-devel, qemu-trivial, Anthoine Bourgeois
Hi Anthoine,
Cc'ing Gerd Hoffmann who is the maintainer of this file.
See
https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer:
$ ./scripts/get_maintainer.pl -f ui/gtk-gl-area.c
Gerd Hoffmann <kraxel@redhat.com> (odd fixer:Graphics)
On 10/02/2017 09:40 AM, Anthoine Bourgeois wrote:
> From: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
>
> The gd_gl_area_scanout_texture must destroy framebuffer if there is
> no texture id instead of no framebuffer id.
> The effect was a black screen with "-vga virtio -display gtk,gl=on"
> options.
> The bug was introduce by a4f113fd "gtk: use framebuffer helper functions."
>
> Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
> ---
> ui/gtk-gl-area.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
> index 18b298f..026b7d7 100644
> --- a/ui/gtk-gl-area.c
> +++ b/ui/gtk-gl-area.c
> @@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl,
>
> gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area));
>
> - if (vc->gfx.guest_fb.framebuffer == 0 ||
> - vc->gfx.w == 0 || vc->gfx.h == 0) {
> + if (backing_id == 0 || vc->gfx.w == 0 || vc->gfx.h == 0) {
> gtk_gl_area_set_scanout_mode(vc, false);
> return;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-08 12:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-02 8:09 [Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer Anthoine Bourgeois
-- strict thread matches above, loose matches on Subject: below --
2017-10-02 10:07 Anthoine Bourgeois
2017-10-02 12:40 Anthoine Bourgeois
2017-11-08 12:49 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).