Re: [Qemu-devel] [PATCH v10 05/20] dirty-bitmap: Avoid size query failure during truncate

[Kevin Wolf <kwolf@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

Am 25.09.2017 um 17:46 hat Eric Blake geschrieben:
> On 09/25/2017 10:23 AM, Vladimir Sementsov-Ogievskiy wrote:
> > 25.09.2017 17:55, Eric Blake wrote:
> >> We've previously fixed several places where we failed to account
> >> for possible errors from bdrv_nb_sectors().  Fix another one by
> >> making bdrv_dirty_bitmap_truncate() take the new size from the
> >> caller instead of querying itself; then adjust the sole caller
> >> bdrv_truncate() to pass the size just determined by a successful
> >> resize, or to skip the bitmap resize on failure, thus avoiding
> > 
> > nothing is skipped in this version
> 
> So much for me squashing in a change.  If the maintainer is willing
> (Kevin, is this going through your tree?), we can reword that to:
> 
> "...pass the size just determined by a successful resize, or to reuse
> the size given to the original truncate operation when
> refresh_total_sectors() was not able to confirm the actual size (the two
> sizes can potentially differ according to rounding constraints), thus
> avoiding..."

I always thought sentences that long were only allowed in German.

Anyway, I'm squashing it in.

Kevin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]