qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: Owen Smith <owen.smith@citrix.com>
Cc: sstabellini@kernel.org, kraxel@redhat.com,
	xen-devel@lists.xenproject.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3 v4] xenfb: Use Input Handlers directly
Date: Mon, 2 Oct 2017 18:33:40 +0100	[thread overview]
Message-ID: <20171002173340.GB2116@perard.uk.xensource.com> (raw)
In-Reply-To: <1506437019-17946-3-git-send-email-owen.smith@citrix.com>

On Tue, Sep 26, 2017 at 02:43:38PM +0000, Owen Smith wrote:
> Avoid the unneccessary calls through the input-legacy.c file by
> using the qemu_input_handler_*() calls directly. This did require
> reworking the event and sync handlers to use the reverse mapping
> from qcode to linux using qemu_input_qcode_to_linux().
> Removes the scancode2linux mapping, and supporting documention.
> 
> Signed-off-by: Owen Smith <owen.smith@citrix.com>

There is a call to trace_xenfb_key_event() that have been added
upstream, just before the call to xenfb_send_key(), that should probably
be added to this patch, otherwise, the patch does not apply. With that
fix, you can add my:
Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD

  reply	other threads:[~2017-10-02 17:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-26 14:43 [Qemu-devel] [PATCH 0/3 v4] xenfb: Enablement for Windows PV HID frontend Owen Smith
2017-09-26 14:43 ` [Qemu-devel] [PATCH 1/3 v4] ui/input: add qemu_input_qcode_to_linux Owen Smith
2017-09-26 14:43 ` [Qemu-devel] [PATCH 2/3 v4] xenfb: Use Input Handlers directly Owen Smith
2017-10-02 17:33   ` Anthony PERARD [this message]
2017-09-26 14:43 ` [Qemu-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer Owen Smith
2017-10-02 17:01   ` Anthony PERARD
2017-10-10 23:52     ` Stefano Stabellini
2017-10-11 15:47       ` Anthony PERARD
2017-10-11 20:19         ` Stefano Stabellini
2017-10-12  7:58           ` [Qemu-devel] [Xen-devel] " Paul Durrant
2017-10-12  9:26             ` Gerd Hoffmann
2017-10-12  9:39               ` Paul Durrant
2017-10-12 17:27                 ` Stefano Stabellini
2017-10-19  9:00                   ` Owen Smith
2017-10-12 10:38           ` [Qemu-devel] " Anthony PERARD
2017-09-29 10:26 ` [Qemu-devel] [PATCH 0/3 v4] xenfb: Enablement for Windows PV HID frontend Gerd Hoffmann
2017-09-29 10:33   ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171002173340.GB2116@perard.uk.xensource.com \
    --to=anthony.perard@citrix.com \
    --cc=kraxel@redhat.com \
    --cc=owen.smith@citrix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).