From: Anthony PERARD <anthony.perard@citrix.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: qemu-devel@nongnu.org, Wei Liu <wei.liu2@citrix.com>,
Juan Quintela <quintela@redhat.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
xen-devel@lists.xenproject.org
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] migration, xen: Fix block image lock issue on live migration
Date: Tue, 3 Oct 2017 12:47:43 +0100 [thread overview]
Message-ID: <20171003114742.GC2116@perard.uk.xensource.com> (raw)
In-Reply-To: <20171003113337.nkde7v236fww3npt@MacBook-Pro-de-Roger.local>
On Tue, Oct 03, 2017 at 12:33:37PM +0100, Roger Pau Monné wrote:
> On Mon, Oct 02, 2017 at 04:30:58PM +0000, Anthony PERARD wrote:
> > When doing a live migration of a Xen guest with libxl, the images for
> > block devices are locked by the original QEMU process, and this prevent
> > the QEMU at the destination to take the lock and the migration fail.
> >
> > From QEMU point of view, once the RAM of a domain is migrated, there is
> > two QMP commands, "stop" then "xen-save-devices-state", at which point a
> > new QEMU is spawned at the destination.
> >
> > Release locks in "xen-save-devices-state" so the destination can takes
> > them.
>
> What happens if the migration fails on the destination? Will QEMU pick
> the lock again when resuming on the source in this case?
Yes, calling the QMP command "cont" to resume the activity makes QEMU
take the lock again, and libxl would call "cont". (I don't think you can
pick this kind of lock ;-). )
--
Anthony PERARD
prev parent reply other threads:[~2017-10-03 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 16:30 [Qemu-devel] [PATCH] migration, xen: Fix block image lock issue on live migration Anthony PERARD
2017-10-02 19:18 ` Dr. David Alan Gilbert
2017-10-04 13:03 ` Kevin Wolf
2017-10-24 12:11 ` Anthony PERARD
2017-10-03 11:33 ` [Qemu-devel] [Xen-devel] " Roger Pau Monné
2017-10-03 11:47 ` Anthony PERARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003114742.GC2116@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=dgilbert@redhat.com \
--cc=ian.jackson@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).