[Qemu-devel] [PATCH v2 0/4] blockjobs: add explicit job reaping

[John Snow <jsnow@redhat.com>]

For jobs that complete when a monitor isn't looking, there's no way to
tell what the job's final return code was. We need to allow jobs to
remain in the list until queried for reliable management.

V2:
 - Added tests!
 - Changed property name (Jeff, Paolo)

RFC:
The next version will add tests for transactions.
Kevin, can you please take a look at bdrv_is_root_node and how it is
used with respect to do_drive_backup? I suspect that in this case that
"is root" should actually be "true", but a node in use by a job has
two roles; child_root and child_job, so it starts returning false here.

That's fine because we prevent a collision that way, but it makes the
error messages pretty bad and misleading. Do you have a quick suggestion?
(Should I just amend the loop to allow non-root nodes as long as they
happen to be jobs so that the job creation code can check permissions?)

John Snow (4):
  blockjob: add persistent property
  qmp: add block-job-reap command
  blockjob: expose persistent property
  iotests: test manual job reaping

 block/backup.c               |  20 ++--
 block/commit.c               |   2 +-
 block/mirror.c               |   2 +-
 block/replication.c          |   5 +-
 block/stream.c               |   2 +-
 block/trace-events           |   1 +
 blockdev.c                   |  28 +++++-
 blockjob.c                   |  46 ++++++++-
 include/block/block_int.h    |   8 +-
 include/block/blockjob.h     |  21 ++++
 include/block/blockjob_int.h |   2 +-
 qapi/block-core.json         |  49 ++++++++--
 tests/qemu-iotests/056       | 227 +++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/056.out   |   4 +-
 tests/test-blockjob-txn.c    |   2 +-
 tests/test-blockjob.c        |   2 +-
 16 files changed, 384 insertions(+), 37 deletions(-)

-- 
2.9.5