From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzZvE-0005Vt-OO for qemu-devel@nongnu.org; Tue, 03 Oct 2017 23:00:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzZvD-00076x-Fg for qemu-devel@nongnu.org; Tue, 03 Oct 2017 23:00:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57084) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzZvD-00076g-A9 for qemu-devel@nongnu.org; Tue, 03 Oct 2017 23:00:31 -0400 From: Eduardo Habkost Date: Wed, 4 Oct 2017 00:00:24 -0300 Message-Id: <20171004030025.7866-2-ehabkost@redhat.com> In-Reply-To: <20171004030025.7866-1-ehabkost@redhat.com> References: <20171004030025.7866-1-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH v3 1/2] vl: Eliminate defconfig variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Markus Armbruster , Paolo Bonzini , Alistair Francis , "Daniel P. Berrange" Both -nodefconfig and -no-user-config options do the same thing today, we only need one variable to keep track of them. Suggested-by: Markus Armbruster Acked-by: Alistair Francis Reviewed-by: Markus Armbruster Signed-off-by: Eduardo Habkost --- vl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/vl.c b/vl.c index 3fed457921..ebea42e0ea 100644 --- a/vl.c +++ b/vl.c @@ -3111,7 +3111,6 @@ int main(int argc, char **argv, char **envp) const char *qtest_log = NULL; const char *pid_file = NULL; const char *incoming = NULL; - bool defconfig = true; bool userconfig = true; bool nographic = false; DisplayType display_type = DT_DEFAULT; @@ -3213,8 +3212,6 @@ int main(int argc, char **argv, char **envp) popt = lookup_opt(argc, argv, &optarg, &optind); switch (popt->index) { case QEMU_OPTION_nodefconfig: - defconfig = false; - break; case QEMU_OPTION_nouserconfig: userconfig = false; break; @@ -3222,7 +3219,7 @@ int main(int argc, char **argv, char **envp) } } - if (defconfig && userconfig) { + if (userconfig) { if (qemu_read_default_config_file() < 0) { exit(1); } -- 2.13.5