From: Fam Zheng <famz@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, jcody@redhat.com,
jsnow@redhat.com, qemu-block@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/5] block: Avoid copy-on-read assertions
Date: Wed, 4 Oct 2017 13:39:35 +0800 [thread overview]
Message-ID: <20171004053935.GB24018@lemon> (raw)
In-Reply-To: <7d6f852d-5186-e488-2f32-861ce5f69c79@redhat.com>
On Tue, 10/03 21:22, Eric Blake wrote:
> On 10/03/2017 09:16 PM, no-reply@patchew.org wrote:
> > Hi,
> >
> > This series failed automatic build test. Please find the testing commands and
> > their output below. If you have docker installed, you can probably reproduce it
> > locally.
> >
>
> > 195 [not run] not suitable for this image format: raw
> > 197 - output mismatch (see 197.out.bad)
> > --- /tmp/qemu-test/src/tests/qemu-iotests/197.out 2017-10-04 01:52:59.000000000 +0000
> > +++ /tmp/qemu-test/build/tests/qemu-iotests/197.out.bad 2017-10-04 02:15:52.212004491 +0000
> > @@ -12,13 +12,18 @@
> > 128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> > read 0/0 bytes at offset 0
> > 0 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> > -read 2147483136/2147483136 bytes at offset 1024
> > -2 GiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> > +
> > +(process:16284): GLib-ERROR **: gmem.c:100: failed to allocate 2147483136 bytes
>
> Okay, a test that requires a nearly-2G read in one operation is fringe,
> and I can see it choking 32-bit platforms rather easily. How do we
> modify the test to not be so mean to memory-starved systems? And why
> didn't patchew complain about this on v1, which had the same ~2G read?
I don't know. The whole system (Fedora VM) is dedicated to patchew test and no
concurrent task should be running. Maybe 2G is just in between the memory
watermarks.
Fam
prev parent reply other threads:[~2017-10-04 5:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 1:43 [Qemu-devel] [PATCH v2 0/5] block: Avoid copy-on-read assertions Eric Blake
2017-10-04 1:43 ` [Qemu-devel] [PATCH v2 1/5] qemu-io: Add -C for opening with copy-on-read Eric Blake
2017-10-04 1:43 ` [Qemu-devel] [PATCH v2 2/5] block: Uniform handling of 0-length bdrv_get_block_status() Eric Blake
2017-10-05 14:35 ` Stefan Hajnoczi
2017-10-05 14:41 ` Eric Blake
2017-10-04 1:43 ` [Qemu-devel] [PATCH v2 3/5] block: Add blkdebug hook for copy-on-read Eric Blake
2017-10-04 1:43 ` [Qemu-devel] [PATCH v2 4/5] block: Perform copy-on-read in loop Eric Blake
2017-10-05 14:55 ` Kevin Wolf
2017-10-05 15:36 ` Stefan Hajnoczi
2017-10-04 1:43 ` [Qemu-devel] [PATCH v2 5/5] iotests: Add test 197 for covering copy-on-read Eric Blake
2017-10-05 14:41 ` Stefan Hajnoczi
2017-10-05 14:44 ` Eric Blake
2017-10-05 14:47 ` Eric Blake
2017-10-04 2:16 ` [Qemu-devel] [PATCH v2 0/5] block: Avoid copy-on-read assertions no-reply
2017-10-04 2:22 ` Eric Blake
2017-10-04 5:39 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004053935.GB24018@lemon \
--to=famz@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).