From: Fam Zheng <famz@redhat.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: qemu-devel@nongnu.org, jgross@suse.com, sstabellini@kernel.org,
xen-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements
Date: Wed, 4 Oct 2017 13:41:43 +0800 [thread overview]
Message-ID: <20171004054143.GC24018@lemon> (raw)
In-Reply-To: <22995.51149.836093.934334@mariner.uk.xensource.com>
On Tue, 10/03 18:24, Ian Jackson wrote:
> no-reply@patchew.org writes ("Re: [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements"):
> > This series seems to have some coding style problems. See output below for
> > more information:
>
> Thanks for this automatic mail. I have sorted out most of these.
> However:
>
> > ERROR: consider using qemu_strtoul in preference to strtoul
> > #41: FILE: os-posix.c:159:
> > + lv = strtoul(optarg, &ep, 0);
>
> In one of these two cases, it is not possible to use qemu_strtoul
> because the expected terminator is '.'. I have added a comment about
> this.
Thanks for taking a look at the report and helping explain. Yes, so the error is
false positive, let's ignore it.
Fam
prev parent reply other threads:[~2017-10-04 5:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 18:09 [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements Ian Jackson
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 1/6] xen: link against xentoolcore Ian Jackson
2017-09-22 12:14 ` Juergen Gross
2017-09-25 15:08 ` Anthony PERARD
2017-09-25 15:16 ` Juergen Gross
2017-09-25 15:01 ` Anthony PERARD
2017-10-03 17:25 ` Ian Jackson
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 2/6] xen: defer call to xen_restrict until running Ian Jackson
2017-09-25 16:08 ` Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 3/6] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2017-09-25 16:15 ` Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 4/6] xen: destroy_hvm_domain: Move reason into a variable Ian Jackson
2017-09-25 16:28 ` Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 5/6] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Ian Jackson
2017-09-25 16:32 ` Anthony PERARD
2017-09-15 18:09 ` [Qemu-devel] [PATCH RFC 6/6] os-posix: Provide new -runasid option Ian Jackson
2017-09-15 18:17 ` [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements no-reply
2017-09-15 18:17 ` no-reply
2017-10-03 17:24 ` Ian Jackson
2017-10-04 5:41 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004054143.GC24018@lemon \
--to=famz@redhat.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).