qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Alistair Francis <alistair23@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/2] vl: Eliminate defconfig variable
Date: Wed, 4 Oct 2017 09:37:19 +0100	[thread overview]
Message-ID: <20171004083719.GF17517@redhat.com> (raw)
In-Reply-To: <20171004030025.7866-2-ehabkost@redhat.com>

On Wed, Oct 04, 2017 at 12:00:24AM -0300, Eduardo Habkost wrote:
> Both -nodefconfig and -no-user-config options do the same thing
> today, we only need one variable to keep track of them.
> 
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Acked-by: Alistair Francis <alistair.francis@xilinx.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  vl.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)


Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  reply	other threads:[~2017-10-04  8:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04  3:00 [Qemu-devel] [PATCH v3 0/2] Deprecate -nodefconfig Eduardo Habkost
2017-10-04  3:00 ` [Qemu-devel] [PATCH v3 1/2] vl: Eliminate defconfig variable Eduardo Habkost
2017-10-04  8:37   ` Daniel P. Berrange [this message]
2017-10-04  3:00 ` [Qemu-devel] [PATCH v3 2/2] qemu-options: Deprecate -nodefconfig Eduardo Habkost
2017-10-04  5:44   ` Markus Armbruster
2017-10-04  8:36   ` Daniel P. Berrange
2017-10-04 20:46 ` [Qemu-devel] [PATCH v3 0/2] " Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004083719.GF17517@redhat.com \
    --to=berrange@redhat.com \
    --cc=alistair23@gmail.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).