* [Qemu-devel] [PATCH] s390x: sort some devices into categories
@ 2017-10-04 9:00 Cornelia Huck
2017-10-04 9:01 ` Christian Borntraeger
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Cornelia Huck @ 2017-10-04 9:00 UTC (permalink / raw)
To: qemu-devel; +Cc: borntraeger, agraf, rth, thuth, Cornelia Huck
Add missing categorizations for some s390x devices:
- zpci device -> misc
- 3270 -> display
- vfio-ccw -> misc
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
hw/s390x/3270-ccw.c | 1 +
hw/s390x/s390-pci-bus.c | 1 +
hw/vfio/ccw.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/hw/s390x/3270-ccw.c b/hw/s390x/3270-ccw.c
index eaca28e224..081e3ef6f4 100644
--- a/hw/s390x/3270-ccw.c
+++ b/hw/s390x/3270-ccw.c
@@ -160,6 +160,7 @@ static void emulated_ccw_3270_class_init(ObjectClass *klass, void *data)
dc->bus_type = TYPE_VIRTUAL_CSS_BUS;
dc->realize = emulated_ccw_3270_realize;
dc->hotpluggable = false;
+ set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
}
static const TypeInfo emulated_ccw_3270_info = {
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index 3b9965fde0..96116b7d1e 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -1032,6 +1032,7 @@ static void s390_pci_device_class_init(ObjectClass *klass, void *data)
DeviceClass *dc = DEVICE_CLASS(klass);
dc->desc = "zpci device";
+ set_bit(DEVICE_CATEGORY_MISC, dc->categories);
dc->reset = s390_pci_device_reset;
dc->bus_type = TYPE_S390_PCI_BUS;
dc->realize = s390_pci_device_realize;
diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
index a8baadf57a..76323c6bde 100644
--- a/hw/vfio/ccw.c
+++ b/hw/vfio/ccw.c
@@ -413,6 +413,7 @@ static void vfio_ccw_class_init(ObjectClass *klass, void *data)
dc->props = vfio_ccw_properties;
dc->vmsd = &vfio_ccw_vmstate;
dc->desc = "VFIO-based subchannel assignment";
+ set_bit(DEVICE_CATEGORY_MISC, dc->categories);
dc->realize = vfio_ccw_realize;
dc->unrealize = vfio_ccw_unrealize;
dc->reset = vfio_ccw_reset;
--
2.13.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] s390x: sort some devices into categories
2017-10-04 9:00 [Qemu-devel] [PATCH] s390x: sort some devices into categories Cornelia Huck
@ 2017-10-04 9:01 ` Christian Borntraeger
2017-10-04 9:20 ` Thomas Huth
2017-10-04 9:55 ` Cornelia Huck
2 siblings, 0 replies; 5+ messages in thread
From: Christian Borntraeger @ 2017-10-04 9:01 UTC (permalink / raw)
To: Cornelia Huck, qemu-devel; +Cc: agraf, rth, thuth
On 10/04/2017 11:00 AM, Cornelia Huck wrote:
> Add missing categorizations for some s390x devices:
> - zpci device -> misc
> - 3270 -> display
> - vfio-ccw -> misc
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> hw/s390x/3270-ccw.c | 1 +
> hw/s390x/s390-pci-bus.c | 1 +
> hw/vfio/ccw.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/hw/s390x/3270-ccw.c b/hw/s390x/3270-ccw.c
> index eaca28e224..081e3ef6f4 100644
> --- a/hw/s390x/3270-ccw.c
> +++ b/hw/s390x/3270-ccw.c
> @@ -160,6 +160,7 @@ static void emulated_ccw_3270_class_init(ObjectClass *klass, void *data)
> dc->bus_type = TYPE_VIRTUAL_CSS_BUS;
> dc->realize = emulated_ccw_3270_realize;
> dc->hotpluggable = false;
> + set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
> }
>
> static const TypeInfo emulated_ccw_3270_info = {
> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
> index 3b9965fde0..96116b7d1e 100644
> --- a/hw/s390x/s390-pci-bus.c
> +++ b/hw/s390x/s390-pci-bus.c
> @@ -1032,6 +1032,7 @@ static void s390_pci_device_class_init(ObjectClass *klass, void *data)
> DeviceClass *dc = DEVICE_CLASS(klass);
>
> dc->desc = "zpci device";
> + set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> dc->reset = s390_pci_device_reset;
> dc->bus_type = TYPE_S390_PCI_BUS;
> dc->realize = s390_pci_device_realize;
> diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
> index a8baadf57a..76323c6bde 100644
> --- a/hw/vfio/ccw.c
> +++ b/hw/vfio/ccw.c
> @@ -413,6 +413,7 @@ static void vfio_ccw_class_init(ObjectClass *klass, void *data)
> dc->props = vfio_ccw_properties;
> dc->vmsd = &vfio_ccw_vmstate;
> dc->desc = "VFIO-based subchannel assignment";
> + set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> dc->realize = vfio_ccw_realize;
> dc->unrealize = vfio_ccw_unrealize;
> dc->reset = vfio_ccw_reset;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] s390x: sort some devices into categories
2017-10-04 9:00 [Qemu-devel] [PATCH] s390x: sort some devices into categories Cornelia Huck
2017-10-04 9:01 ` Christian Borntraeger
@ 2017-10-04 9:20 ` Thomas Huth
2017-10-04 9:52 ` Cornelia Huck
2017-10-04 9:55 ` Cornelia Huck
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2017-10-04 9:20 UTC (permalink / raw)
To: Cornelia Huck, qemu-devel; +Cc: borntraeger, agraf, rth
On 04.10.2017 11:00, Cornelia Huck wrote:
> Add missing categorizations for some s390x devices:
> - zpci device -> misc
> - 3270 -> display
> - vfio-ccw -> misc
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/s390x/3270-ccw.c | 1 +
> hw/s390x/s390-pci-bus.c | 1 +
> hw/vfio/ccw.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/hw/s390x/3270-ccw.c b/hw/s390x/3270-ccw.c
> index eaca28e224..081e3ef6f4 100644
> --- a/hw/s390x/3270-ccw.c
> +++ b/hw/s390x/3270-ccw.c
> @@ -160,6 +160,7 @@ static void emulated_ccw_3270_class_init(ObjectClass *klass, void *data)
> dc->bus_type = TYPE_VIRTUAL_CSS_BUS;
> dc->realize = emulated_ccw_3270_realize;
> dc->hotpluggable = false;
> + set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
While you're at it, add a proper dc->desc ?
> }
>
> static const TypeInfo emulated_ccw_3270_info = {
> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
> index 3b9965fde0..96116b7d1e 100644
> --- a/hw/s390x/s390-pci-bus.c
> +++ b/hw/s390x/s390-pci-bus.c
> @@ -1032,6 +1032,7 @@ static void s390_pci_device_class_init(ObjectClass *klass, void *data)
> DeviceClass *dc = DEVICE_CLASS(klass);
>
> dc->desc = "zpci device";
While you're at it, add better desc?
> + set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> dc->reset = s390_pci_device_reset;
> dc->bus_type = TYPE_S390_PCI_BUS;
> dc->realize = s390_pci_device_realize;
> diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
> index a8baadf57a..76323c6bde 100644
> --- a/hw/vfio/ccw.c
> +++ b/hw/vfio/ccw.c
> @@ -413,6 +413,7 @@ static void vfio_ccw_class_init(ObjectClass *klass, void *data)
> dc->props = vfio_ccw_properties;
> dc->vmsd = &vfio_ccw_vmstate;
> dc->desc = "VFIO-based subchannel assignment";
> + set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> dc->realize = vfio_ccw_realize;
> dc->unrealize = vfio_ccw_unrealize;
> dc->reset = vfio_ccw_reset;
>
Anyway, it's also fine without better descs, so:
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] s390x: sort some devices into categories
2017-10-04 9:20 ` Thomas Huth
@ 2017-10-04 9:52 ` Cornelia Huck
0 siblings, 0 replies; 5+ messages in thread
From: Cornelia Huck @ 2017-10-04 9:52 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, borntraeger, agraf, rth
On Wed, 4 Oct 2017 11:20:00 +0200
Thomas Huth <thuth@redhat.com> wrote:
> On 04.10.2017 11:00, Cornelia Huck wrote:
> > Add missing categorizations for some s390x devices:
> > - zpci device -> misc
> > - 3270 -> display
> > - vfio-ccw -> misc
> >
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> > hw/s390x/3270-ccw.c | 1 +
> > hw/s390x/s390-pci-bus.c | 1 +
> > hw/vfio/ccw.c | 1 +
> > 3 files changed, 3 insertions(+)
> >
> > diff --git a/hw/s390x/3270-ccw.c b/hw/s390x/3270-ccw.c
> > index eaca28e224..081e3ef6f4 100644
> > --- a/hw/s390x/3270-ccw.c
> > +++ b/hw/s390x/3270-ccw.c
> > @@ -160,6 +160,7 @@ static void emulated_ccw_3270_class_init(ObjectClass *klass, void *data)
> > dc->bus_type = TYPE_VIRTUAL_CSS_BUS;
> > dc->realize = emulated_ccw_3270_realize;
> > dc->hotpluggable = false;
> > + set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
>
> While you're at it, add a proper dc->desc ?
>
> > }
> >
> > static const TypeInfo emulated_ccw_3270_info = {
> > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
> > index 3b9965fde0..96116b7d1e 100644
> > --- a/hw/s390x/s390-pci-bus.c
> > +++ b/hw/s390x/s390-pci-bus.c
> > @@ -1032,6 +1032,7 @@ static void s390_pci_device_class_init(ObjectClass *klass, void *data)
> > DeviceClass *dc = DEVICE_CLASS(klass);
> >
> > dc->desc = "zpci device";
>
> While you're at it, add better desc?
Hey, it's not wrong :) (and I can't really think of a good one...)
>
> > + set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> > dc->reset = s390_pci_device_reset;
> > dc->bus_type = TYPE_S390_PCI_BUS;
> > dc->realize = s390_pci_device_realize;
> > diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
> > index a8baadf57a..76323c6bde 100644
> > --- a/hw/vfio/ccw.c
> > +++ b/hw/vfio/ccw.c
> > @@ -413,6 +413,7 @@ static void vfio_ccw_class_init(ObjectClass *klass, void *data)
> > dc->props = vfio_ccw_properties;
> > dc->vmsd = &vfio_ccw_vmstate;
> > dc->desc = "VFIO-based subchannel assignment";
> > + set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> > dc->realize = vfio_ccw_realize;
> > dc->unrealize = vfio_ccw_unrealize;
> > dc->reset = vfio_ccw_reset;
> >
>
> Anyway, it's also fine without better descs, so:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] s390x: sort some devices into categories
2017-10-04 9:00 [Qemu-devel] [PATCH] s390x: sort some devices into categories Cornelia Huck
2017-10-04 9:01 ` Christian Borntraeger
2017-10-04 9:20 ` Thomas Huth
@ 2017-10-04 9:55 ` Cornelia Huck
2 siblings, 0 replies; 5+ messages in thread
From: Cornelia Huck @ 2017-10-04 9:55 UTC (permalink / raw)
To: qemu-devel; +Cc: borntraeger, agraf, rth, thuth
On Wed, 4 Oct 2017 11:00:32 +0200
Cornelia Huck <cohuck@redhat.com> wrote:
> Add missing categorizations for some s390x devices:
> - zpci device -> misc
> - 3270 -> display
> - vfio-ccw -> misc
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/s390x/3270-ccw.c | 1 +
> hw/s390x/s390-pci-bus.c | 1 +
> hw/vfio/ccw.c | 1 +
> 3 files changed, 3 insertions(+)
Queued to s390-next.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-04 9:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-04 9:00 [Qemu-devel] [PATCH] s390x: sort some devices into categories Cornelia Huck
2017-10-04 9:01 ` Christian Borntraeger
2017-10-04 9:20 ` Thomas Huth
2017-10-04 9:52 ` Cornelia Huck
2017-10-04 9:55 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).