* [Qemu-devel] [PATCH] checkpatch: fix incompatibility with old perl
@ 2017-10-04 15:44 Vladimir Sementsov-Ogievskiy
2017-10-04 15:49 ` Alex Williamson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2017-10-04 15:44 UTC (permalink / raw)
To: qemu-devel; +Cc: vsementsov, stefanha, alex.williamson, berrange
Do not use '/r' modifier which was introduced in perl 5.14.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3c0a28e644..0c41f1212f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1432,7 +1432,8 @@ sub process {
qr/%[-+ *.0-9]*([hljztL]|ll|hh)?(x|X|"\s*PRI[xX][^"]*"?)/;
# don't consider groups splitted by [.:/ ], like 2A.20:12ab
- my $tmpline = $rawline =~ s/($hex[.:\/ ])+$hex//gr;
+ my $tmpline = $rawline;
+ $tmpline =~ s/($hex[.:\/ ])+$hex//g;
if ($tmpline =~ /(?<!0x)$hex/) {
ERROR("Hex numbers must be prefixed with '0x'\n" .
--
2.11.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] checkpatch: fix incompatibility with old perl
2017-10-04 15:44 [Qemu-devel] [PATCH] checkpatch: fix incompatibility with old perl Vladimir Sementsov-Ogievskiy
@ 2017-10-04 15:49 ` Alex Williamson
2017-10-04 16:28 ` Daniel P. Berrange
2017-10-05 14:24 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Alex Williamson @ 2017-10-04 15:49 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy; +Cc: qemu-devel, stefanha, berrange
On Wed, 4 Oct 2017 18:44:20 +0300
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> wrote:
> Do not use '/r' modifier which was introduced in perl 5.14.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
Fixes: 3e5875afc0f ("checkpatch: check trace-events code style")
Tested-by: Alex Williamson <alex.williamson@redhat.com>
Thanks
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 3c0a28e644..0c41f1212f 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1432,7 +1432,8 @@ sub process {
> qr/%[-+ *.0-9]*([hljztL]|ll|hh)?(x|X|"\s*PRI[xX][^"]*"?)/;
>
> # don't consider groups splitted by [.:/ ], like 2A.20:12ab
> - my $tmpline = $rawline =~ s/($hex[.:\/ ])+$hex//gr;
> + my $tmpline = $rawline;
> + $tmpline =~ s/($hex[.:\/ ])+$hex//g;
>
> if ($tmpline =~ /(?<!0x)$hex/) {
> ERROR("Hex numbers must be prefixed with '0x'\n" .
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] checkpatch: fix incompatibility with old perl
2017-10-04 15:44 [Qemu-devel] [PATCH] checkpatch: fix incompatibility with old perl Vladimir Sementsov-Ogievskiy
2017-10-04 15:49 ` Alex Williamson
@ 2017-10-04 16:28 ` Daniel P. Berrange
2017-10-05 14:24 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrange @ 2017-10-04 16:28 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy; +Cc: qemu-devel, stefanha, alex.williamson
On Wed, Oct 04, 2017 at 06:44:20PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Do not use '/r' modifier which was introduced in perl 5.14.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 3c0a28e644..0c41f1212f 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1432,7 +1432,8 @@ sub process {
> qr/%[-+ *.0-9]*([hljztL]|ll|hh)?(x|X|"\s*PRI[xX][^"]*"?)/;
>
> # don't consider groups splitted by [.:/ ], like 2A.20:12ab
> - my $tmpline = $rawline =~ s/($hex[.:\/ ])+$hex//gr;
> + my $tmpline = $rawline;
> + $tmpline =~ s/($hex[.:\/ ])+$hex//g;
>
> if ($tmpline =~ /(?<!0x)$hex/) {
> ERROR("Hex numbers must be prefixed with '0x'\n" .
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] checkpatch: fix incompatibility with old perl
2017-10-04 15:44 [Qemu-devel] [PATCH] checkpatch: fix incompatibility with old perl Vladimir Sementsov-Ogievskiy
2017-10-04 15:49 ` Alex Williamson
2017-10-04 16:28 ` Daniel P. Berrange
@ 2017-10-05 14:24 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2017-10-05 14:24 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy; +Cc: qemu-devel, alex.williamson, berrange
On Wed, Oct 04, 2017 at 06:44:20PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Do not use '/r' modifier which was introduced in perl 5.14.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-05 14:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-04 15:44 [Qemu-devel] [PATCH] checkpatch: fix incompatibility with old perl Vladimir Sementsov-Ogievskiy
2017-10-04 15:49 ` Alex Williamson
2017-10-04 16:28 ` Daniel P. Berrange
2017-10-05 14:24 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).