From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzjOq-0001FW-Po for qemu-devel@nongnu.org; Wed, 04 Oct 2017 09:07:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzjOl-00061V-10 for qemu-devel@nongnu.org; Wed, 04 Oct 2017 09:07:44 -0400 Date: Wed, 4 Oct 2017 10:06:55 -0300 From: Eduardo Habkost Message-ID: <20171004130655.GK4760@localhost.localdomain> References: <20170927195635.16014-1-ehabkost@redhat.com> <20170927195635.16014-5-ehabkost@redhat.com> <59CCD0150200007800180507@prv-mh.provo.novell.com> <20170928131234.GP4115@localhost.localdomain> <20171003001257.GA7087@localhost.localdomain> <59D4C11F0200007800181F48@prv-mh.provo.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59D4C11F0200007800181F48@prv-mh.provo.novell.com> Subject: Re: [Qemu-devel] xen-pci-passthrough PCI Express support? (Re: [Xen-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Beulich Cc: Aurelien Jarno , Anthony Perard , David Gibson , Alistair Francis , Artyom Tarasenko , Alberto Garcia , Mark Cave-Ayland , Yongbok Kim , Stefano Stabellini , Peter Maydell , xen-devel@lists.xenproject.org, qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, =?iso-8859-1?Q?Herv=E9?= Poussineau , Alex Williamson , David Gibson , Igor Mammedov , Jason Wang , John Snow , Gerd Hoffmann , Laine Stump , Marcel Apfelbaum , "Michael S. Tsirkin" , Paolo Bonzini , Jiri Pirko , Hannes Reinecke , Jiri Slaby , Alexander Graf , Richard Henderson On Wed, Oct 04, 2017 at 03:08:15AM -0600, Jan Beulich wrote: > >>> On 03.10.17 at 02:12, wrote: > > On Thu, Sep 28, 2017 at 10:12:34AM -0300, Eduardo Habkost wrote: > >> On Thu, Sep 28, 2017 at 02:33:57AM -0600, Jan Beulich wrote: > >> > >>> On 27.09.17 at 21:56, wrote: > >> > > --- a/hw/xen/xen_pt.c > >> > > +++ b/hw/xen/xen_pt.c > >> > > @@ -964,6 +964,10 @@ static const TypeInfo xen_pci_passthrough_info = { > >> > > .instance_size = sizeof(XenPCIPassthroughState), > >> > > .instance_finalize = xen_pci_passthrough_finalize, > >> > > .class_init = xen_pci_passthrough_class_init, > >> > > + .interfaces = (InterfaceInfo[]) { > >> > > + { INTERFACE_CONVENTIONAL_PCI_DEVICE }, > >> > > + { }, > >> > > + }, > >> > > }; > >> > > >> > Passed through devices can be both PCI and PCIe, so following > >> > the description of the patch I don't think these can be statically > >> > given either property. Granted quite a bit of PCIe specific > >> > functionality may be missing in the Xen code ... > >> > >> This is just static data about what the device type supports, not > >> about what a given device instance really is. Deciding if the > >> device is PCIe or Conventional at runtime is out of the scope of > >> this series. > >> > >> That said, if passed through PCI Express devices are really > >> supported, it looks like this should be marked as hybrid. > > > > Can anybody confirm if PCI Express devices are really supported > > by xen-pci-passthrough? > > I think I've clearly said they're supported, with some limitations. Sorry, thanks. I thought the possible missing PCIe functionality could mean the device couldn't appear as PCI Express to the guest. I will submit a follow-up patch adding INTERFACE_PCIE_DEVICE to xen-pci-passthrough. -- Eduardo