From: Greg Kurz <groug@kaod.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] spapr: fix RTAS method name in comment
Date: Wed, 4 Oct 2017 14:33:43 +0200 [thread overview]
Message-ID: <20171004143343.4a4c120e@bahia.lan> (raw)
In-Reply-To: <20171004094226.GX3260@umbus.fritz.box>
[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]
On Wed, 4 Oct 2017 20:42:26 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Wed, Oct 04, 2017 at 10:43:18AM +0200, Greg Kurz wrote:
> > Signed-off-by: Greg Kurz <groug@kaod.org>
>
> Applied, except I corrected the short description.
> ibm,client-architecture-support is an OF word, not actually an RTAS
> method.
>
Oops you're right... not quite sure what I was thinking to when I wrote
that :)
> > ---
> > hw/ppc/spapr.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> > index 352ff3d614e8..b284e0b9d43e 100644
> > --- a/hw/ppc/spapr.c
> > +++ b/hw/ppc/spapr.c
> > @@ -2334,7 +2334,8 @@ static void ppc_spapr_init(MachineState *machine)
> > /* Set up Interrupt Controller before we create the VCPUs */
> > xics_system_init(machine, XICS_IRQS_SPAPR, &error_fatal);
> >
> > - /* Set up containers for ibm,client-set-architecture negotiated options */
> > + /* Set up containers for ibm,client-architecture-support negotiated options
> > + */
> > spapr->ov5 = spapr_ovec_new();
> > spapr->ov5_cas = spapr_ovec_new();
> >
> >
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2017-10-04 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 8:43 [Qemu-devel] [PATCH] spapr: fix RTAS method name in comment Greg Kurz
2017-10-04 9:42 ` David Gibson
2017-10-04 12:33 ` Greg Kurz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004143343.4a4c120e@bahia.lan \
--to=groug@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).