From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzivU-0003Mj-On for qemu-devel@nongnu.org; Wed, 04 Oct 2017 08:37:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzivU-0008PX-25 for qemu-devel@nongnu.org; Wed, 04 Oct 2017 08:37:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49820) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzivT-0008Oy-Rq for qemu-devel@nongnu.org; Wed, 04 Oct 2017 08:37:23 -0400 Date: Wed, 4 Oct 2017 14:37:19 +0200 From: Cornelia Huck Message-ID: <20171004143719.509ac496.cohuck@redhat.com> In-Reply-To: <20171004110109.16525-1-pasic@linux.vnet.ibm.com> References: <20171004110109.16525-1-pasic@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] s390x/css: fix css migration compat handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic Cc: Thomas Huth , qemu-devel@nongnu.org On Wed, 4 Oct 2017 13:01:09 +0200 Halil Pasic wrote: > Commit e996583eb3 ("s390x/css: activate ChannelSubSys migration", > 2017-07-11) was supposed to enable css migration for virtio-ccw > machines starting 2.10, but it ended up effectively enabling it > only for 2.10 as the registration of the appropriate VMStateDescription > happens in ccw_machine_2_10_instance_options which does not get > called for machines more recent than 2_10. > > Let us move the corresponding chunk of code (which conditionally enables > the migration based on the value of the corresponding class property) to > a ccw_init, which is called for each virtio-ccw machine instance. > > Signed-off-by: Halil Pasic > Reported-by: Thomas Huth > --- > hw/s390x/s390-virtio-ccw.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Thanks, applied.