From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzkEJ-0003zp-1a for qemu-devel@nongnu.org; Wed, 04 Oct 2017 10:01:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzkE9-00057x-DY for qemu-devel@nongnu.org; Wed, 04 Oct 2017 10:00:55 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:45448) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzkE8-00054Z-MM for qemu-devel@nongnu.org; Wed, 04 Oct 2017 10:00:45 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v94Dwxop115956 for ; Wed, 4 Oct 2017 10:00:39 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2dcx4utvng-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 04 Oct 2017 10:00:38 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Oct 2017 15:00:35 +0100 Date: Wed, 4 Oct 2017 16:00:31 +0200 From: Claudio Imbrenda In-Reply-To: <1507125199-22562-1-git-send-email-thuth@redhat.com> References: <1507125199-22562-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20171004160031.2fadaf0e@p-imbrenda.boeblingen.de.ibm.com> Subject: Re: [Qemu-devel] [PATCH] hw/s390x/sclp: Mark the sclp device with user_creatable = false List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, Cornelia Huck , Christian Borntraeger , Dong Jia Shi , Eric Farman , Farhan Ali , Fei Li , Halil Pasic , Janosch Frank , Jason J Herne , Jing Liu , Pierre Morel , QingFeng Hao , Xiao Feng Ren , Yang Chen , Yi Min Zhao On Wed, 4 Oct 2017 15:53:19 +0200 Thomas Huth wrote: > The "sclp" device is just an internal device that can not be > instantiated by the users. If they try to use it, they only get a > simple error message: > > $ qemu-system-s390x -nographic -device sclp > qemu-system-s390x: Option '-device s390-sclp-event-facility' cannot be > handled by this machine > > Since sclp_init() tries to create a TYPE_SCLP_EVENT_FACILITY which is > a non-pluggable sysbus device, there is really no way that the "sclp" > device can be used by the user, so let's set the user_creatable = > false accordingly. > > Signed-off-by: Thomas Huth > --- > hw/s390x/sclp.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c > index 30aefbf..9be0cb8 100644 > --- a/hw/s390x/sclp.c > +++ b/hw/s390x/sclp.c > @@ -606,6 +606,11 @@ static void sclp_class_init(ObjectClass *oc, > void *data) dc->realize = sclp_realize; > dc->hotpluggable = false; > set_bit(DEVICE_CATEGORY_MISC, dc->categories); > + /* > + * Reason: Creates TYPE_SCLP_EVENT_FACILITY in sclp_init > + * which is a non-pluggable sysbus device > + */ > + dc->user_creatable = false; > > sc->read_SCP_info = read_SCP_info; > sc->read_storage_element0_info = read_storage_element0_info; makes sense Reviewed-by: Claudio Imbrenda