qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: [Qemu-devel] [PULL 1/5] hmp: Missing handle_errors
Date: Thu,  5 Oct 2017 11:51:53 +0100	[thread overview]
Message-ID: <20171005105157.10831-2-dgilbert@redhat.com> (raw)
In-Reply-To: <20171005105157.10831-1-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

hmp_info_memdev && hmp_info_memory_devices were missing
hmp_handle_error calls.  Add them.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20170817104216.29150-2-dgilbert@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 hmp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hmp.c b/hmp.c
index ace729d03f..739d330f4e 100644
--- a/hmp.c
+++ b/hmp.c
@@ -2394,6 +2394,7 @@ void hmp_info_memdev(Monitor *mon, const QDict *qdict)
     monitor_printf(mon, "\n");
 
     qapi_free_MemdevList(memdev_list);
+    hmp_handle_error(mon, &err);
 }
 
 void hmp_info_memory_devices(Monitor *mon, const QDict *qdict)
@@ -2432,6 +2433,7 @@ void hmp_info_memory_devices(Monitor *mon, const QDict *qdict)
     }
 
     qapi_free_MemoryDeviceInfoList(info_list);
+    hmp_handle_error(mon, &err);
 }
 
 void hmp_info_iothreads(Monitor *mon, const QDict *qdict)
-- 
2.13.6

  reply	other threads:[~2017-10-05 10:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05 10:51 [Qemu-devel] [PULL 0/5] hmp queue Dr. David Alan Gilbert (git)
2017-10-05 10:51 ` Dr. David Alan Gilbert (git) [this message]
2017-10-05 10:51 ` [Qemu-devel] [PULL 2/5] hmp: Fix unknown command for subtable Dr. David Alan Gilbert (git)
2017-10-05 10:51 ` [Qemu-devel] [PULL 3/5] hmp-commands-info: Fix "info rocker-FOO" misspellings Dr. David Alan Gilbert (git)
2017-10-05 12:47   ` Paolo Bonzini
2017-10-05 14:21     ` Dr. David Alan Gilbert
2017-10-06  5:46     ` Markus Armbruster
2017-10-05 10:51 ` [Qemu-devel] [PULL 4/5] hmp-commands-info: Move Texinfo stanzas to conventional place Dr. David Alan Gilbert (git)
2017-10-05 10:51 ` [Qemu-devel] [PULL 5/5] hmp-commands-info: Change "@findex FOO" to "@findex info FOO" Dr. David Alan Gilbert (git)
2017-10-05 15:53 ` [Qemu-devel] [PULL 0/5] hmp queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171005105157.10831-2-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).