From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, jsnow@redhat.com,
stefanha@redhat.com, qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH v3 0/6] block: Avoid copy-on-read assertions
Date: Thu, 5 Oct 2017 14:02:42 -0500 [thread overview]
Message-ID: <20171005190248.5537-1-eblake@redhat.com> (raw)
During my quest to switch block status to be byte-based, John
forced me to evaluate whether we have a situation during
copy-on-read where we could exceed BDRV_REQUEST_MAX_BYTES [1].
Sure enough, we have a number of pre-existing bugs in the
copy-on-read code. Fix those, along with adding a test.
Available as a tag at:
git fetch git://repo.or.cz/qemu/ericb.git nbd-copy-on-read-v3
Since v2 (available at [2]):
- add a new patch to fix an iotests wart
- tweak patch 5 (now 6) to skip rather than fail on limited memory [patchew]
- tweak patch 2 condition for legibility [Stefan]
- add R-b
[1] https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg07286.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg00524.html
001/6:[----] [--] 'qemu-io: Add -C for opening with copy-on-read'
002/6:[0008] [FC] 'block: Uniform handling of 0-length bdrv_get_block_status()'
003/6:[down] 'iotests: Restore stty settings on completion'
004/6:[----] [--] 'block: Add blkdebug hook for copy-on-read'
005/6:[----] [--] 'block: Perform copy-on-read in loop'
006/6:[0013] [FC] 'iotests: Add test 197 for covering copy-on-read'
Eric Blake (6):
qemu-io: Add -C for opening with copy-on-read
block: Uniform handling of 0-length bdrv_get_block_status()
iotests: Restore stty settings on completion
block: Add blkdebug hook for copy-on-read
block: Perform copy-on-read in loop
iotests: Add test 197 for covering copy-on-read
qapi/block-core.json | 5 +-
block/io.c | 123 +++++++++++++++++++++++++++------------
qemu-io.c | 15 ++++-
tests/qemu-iotests/common.filter | 1 +
tests/qemu-iotests/197 | 109 ++++++++++++++++++++++++++++++++++
tests/qemu-iotests/197.out | 26 +++++++++
tests/qemu-iotests/check | 10 ++++
tests/qemu-iotests/group | 1 +
8 files changed, 249 insertions(+), 41 deletions(-)
create mode 100755 tests/qemu-iotests/197
create mode 100644 tests/qemu-iotests/197.out
--
2.13.6
next reply other threads:[~2017-10-05 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 19:02 Eric Blake [this message]
2017-10-05 19:02 ` [Qemu-devel] [PATCH v3 1/6] qemu-io: Add -C for opening with copy-on-read Eric Blake
2017-10-05 19:02 ` [Qemu-devel] [PATCH v3 2/6] block: Uniform handling of 0-length bdrv_get_block_status() Eric Blake
2017-10-05 19:02 ` [Qemu-devel] [PATCH v3 3/6] iotests: Restore stty settings on completion Eric Blake
2017-10-05 19:02 ` [Qemu-devel] [PATCH v3 4/6] block: Add blkdebug hook for copy-on-read Eric Blake
2017-10-05 19:02 ` [Qemu-devel] [PATCH v3 5/6] block: Perform copy-on-read in loop Eric Blake
2017-10-05 19:02 ` [Qemu-devel] [PATCH v3 6/6] iotests: Add test 197 for covering copy-on-read Eric Blake
2017-10-06 12:17 ` [Qemu-devel] [PATCH v3 0/6] block: Avoid copy-on-read assertions Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005190248.5537-1-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).