From: Kevin Wolf <kwolf@redhat.com>
To: Doug Gale <doug16k@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
qemu-block@nongnu.org, keith.busch@intel.com, mreitz@redhat.com,
stefanha@redhat.com
Subject: Re: [Qemu-devel] Patch to add helpful tracing output for driver authors in NVMe emulation
Date: Fri, 6 Oct 2017 11:49:56 +0200 [thread overview]
Message-ID: <20171006094956.GB4325@localhost.localdomain> (raw)
In-Reply-To: <CAEfK_45dZvxvBNQpPLo71ZJhrPN5_GJr8uJ2pJZpCaFf0+i3YA@mail.gmail.com>
Am 06.10.2017 um 01:18 hat Doug Gale geschrieben:
> I added the tracing output in this patch to assist me in implementing
> an NVMe driver. It helped tremendously.
>
> From 1d19086cdef8d492929852d582cb41dcc5026f71 Mon Sep 17 00:00:00 2001
> From: Doug Gale <doug16k@gmail.com>
> Date: Thu, 5 Oct 2017 19:02:03 -0400
> Subject: [PATCH] Add tracing output to NVMe emulation to help driver authors.
>
> It is off by default, enable it by uncommenting #define DEBUG_NVME
> or through CFLAGS
>
> Signed-off-by: Doug Gale <doug16k@gmail.com>
I think it's generally preferable to use the actual tracing
infrastructure instead of fprintf. This would allow to enable the trace
points with the command line options instead of only at compile time and
also to get machine-readable output if necessary.
The tracing infrastructure is documented in docs/devel/tracing.txt.
Kevin
next prev parent reply other threads:[~2017-10-06 9:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 23:18 [Qemu-devel] Patch to add helpful tracing output for driver authors in NVMe emulation Doug Gale
2017-10-06 9:49 ` Kevin Wolf [this message]
2017-10-06 13:53 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-10-06 13:50 ` [Qemu-devel] " Eric Blake
2017-10-06 13:54 ` Daniel P. Berrange
2017-10-06 13:58 ` Doug Gale
2017-10-06 14:01 ` Daniel P. Berrange
2017-10-07 7:51 ` Doug Gale
2017-10-09 15:52 ` Eric Blake
2017-10-09 18:44 ` Doug Gale
2017-10-10 6:58 ` Markus Armbruster
2017-10-10 8:02 ` Kevin Wolf
2017-10-11 13:03 ` Doug Gale
2017-10-11 13:08 ` Peter Maydell
2017-10-11 19:46 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171006094956.GB4325@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=doug16k@gmail.com \
--cc=keith.busch@intel.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).