Re: [Qemu-devel] [PATCH] io: Add missing GCC_FMT_ATTR (fix -Werror=suggest-attribute=format)

["Daniel P. Berrange" <berrange@redhat.com>]

On Sat, Oct 07, 2017 at 04:56:09PM +0200, Stefan Weil wrote:
> This fixes a compiler warning:
> 
> /qemu/io/channel-websock.c:163:5: error:
>  function might be possible candidate for ‘gnu_printf’ format attribute
>  [-Werror=suggest-attribute=format]
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  io/channel-websock.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Acked-by: Daniel P. Berrange <berrange@redhat.com>


> 
> diff --git a/io/channel-websock.c b/io/channel-websock.c
> index d1d471f86e..7bf1340958 100644
> --- a/io/channel-websock.c
> +++ b/io/channel-websock.c
> @@ -151,9 +151,10 @@ enum {
>      QIO_CHANNEL_WEBSOCK_OPCODE_PONG = 0xA
>  };
>  
> -static void qio_channel_websock_handshake_send_res(QIOChannelWebsock *ioc,
> -                                                   const char *resmsg,
> -                                                   ...)
> +static void GCC_FMT_ATTR(2, 3)
> +qio_channel_websock_handshake_send_res(QIOChannelWebsock *ioc,
> +                                       const char *resmsg,
> +                                       ...)
>  {
>      va_list vargs;
>      char *response;

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|