[Qemu-devel] [RFC PATCH] linux-user/main: support dfilter

[Qemu-devel] [RFC PATCH] linux-user/main: support dfilter

[Alex Bennée]

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 linux-user/main.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/linux-user/main.c b/linux-user/main.c
index 829f974662..5072aa855b 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -3854,6 +3854,11 @@ static void handle_arg_log(const char *arg)
     qemu_set_log(mask);
 }
 
+static void handle_arg_dfilter(const char *arg)
+{
+    qemu_set_dfilter_ranges(arg, NULL);
+}
+
 static void handle_arg_log_filename(const char *arg)
 {
     qemu_set_log_filename(arg, &error_fatal);
@@ -4054,6 +4059,8 @@ static const struct qemu_argument arg_table[] = {
     {"d",          "QEMU_LOG",         true,  handle_arg_log,
      "item[,...]", "enable logging of specified items "
      "(use '-d help' for a list of items)"},
+    {"dfilter",    "QEMU_DFILTER",     true,  handle_arg_dfilter,
+     "range[,...]","filter logging based on address range"},
     {"D",          "QEMU_LOG_FILENAME", true, handle_arg_log_filename,
      "logfile",     "write logs to 'logfile' (default stderr)"},
     {"p",          "QEMU_PAGESIZE",    true,  handle_arg_pagesize,
-- 
2.14.1

Re: [Qemu-devel] [RFC PATCH] linux-user/main: support dfilter

[Laurent Vivier]

Le 09/10/2017 à 17:19, Alex Bennée a écrit :
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  linux-user/main.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 829f974662..5072aa855b 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -3854,6 +3854,11 @@ static void handle_arg_log(const char *arg)
>      qemu_set_log(mask);
>  }
>  
> +static void handle_arg_dfilter(const char *arg)
> +{
> +    qemu_set_dfilter_ranges(arg, NULL);
> +}
> +
>  static void handle_arg_log_filename(const char *arg)
>  {
>      qemu_set_log_filename(arg, &error_fatal);
> @@ -4054,6 +4059,8 @@ static const struct qemu_argument arg_table[] = {
>      {"d",          "QEMU_LOG",         true,  handle_arg_log,
>       "item[,...]", "enable logging of specified items "
>       "(use '-d help' for a list of items)"},
> +    {"dfilter",    "QEMU_DFILTER",     true,  handle_arg_dfilter,
> +     "range[,...]","filter logging based on address range"},
>      {"D",          "QEMU_LOG_FILENAME", true, handle_arg_log_filename,
>       "logfile",     "write logs to 'logfile' (default stderr)"},
>      {"p",          "QEMU_PAGESIZE",    true,  handle_arg_pagesize,
> 

It's really an interesting feature, I think it will be very useful to
debug linux-user QEMU.

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [Qemu-devel] [RFC PATCH] linux-user/main: support dfilter

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20171009151926.1708-1-alex.bennee@linaro.org
Subject: [Qemu-devel] [RFC PATCH] linux-user/main: support dfilter

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1507564902-9000-1-git-send-email-ian.jackson@eu.citrix.com -> patchew/1507564902-9000-1-git-send-email-ian.jackson@eu.citrix.com
 t [tag update]            patchew/20171009151926.1708-1-alex.bennee@linaro.org -> patchew/20171009151926.1708-1-alex.bennee@linaro.org
 * [new tag]               patchew/20171009155431.14093-1-mreitz@redhat.com -> patchew/20171009155431.14093-1-mreitz@redhat.com
Switched to a new branch 'test'
05158b0e6a linux-user/main: support dfilter

=== OUTPUT BEGIN ===
Checking PATCH 1/1: linux-user/main: support dfilter...
ERROR: space required after that ',' (ctx:VxV)
#34: FILE: linux-user/main.c:4063:
+     "range[,...]","filter logging based on address range"},
                   ^

total: 1 errors, 0 warnings, 19 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org